Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/solace] Tests failing on Windows #17197

Closed
dmitryax opened this issue Dec 22, 2022 · 9 comments · Fixed by #17202
Closed

[receiver/solace] Tests failing on Windows #17197

dmitryax opened this issue Dec 22, 2022 · 9 comments · Fixed by #17202
Labels
bug Something isn't working flaky test a test is flaky priority:p2 Medium receiver/solace

Comments

@dmitryax
Copy link
Member

dmitryax commented Dec 22, 2022 •
edited
Loading

The following tests are failing on Windows after #16570:

--- FAIL: TestReceiverFlowControlDelayedRetry (0.04s)
    --- FAIL: TestReceiverFlowControlDelayedRetry/Without_error (0.02s)
    --- PASS: TestReceiverFlowControlDelayedRetry/With_error (0.01s)
=== RUN   TestReceiverFlowControlDelayedRetryInterrupt
--- PASS: TestReceiverFlowControlDelayedRetryInterrupt (0.02s)
=== RUN   TestReceiverFlowControlDelayedRetryMultipleRetries
    receiver_test.go:507: 
        	Error Trace:	D:\a\opentelemetry-collector-contrib\opentelemetry-collector-contrib\receiver\solacereceiver\receiver_test.go:507
        	Error:      	receiveMessage did not return after some time
        	Test:       	TestReceiverFlowControlDelayedRetryMultipleRetries
--- FAIL: TestReceiverFlowControlDelayedRetryMultipleRetries (0.04s)

See https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/3754566082/jobs/6378899100

It was not caught before because of #17181
@dmitryax dmitryax added bug Something isn't working priority:p2 Medium receiver/solace labels Dec 22, 2022
@github-actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions
Copy link
Contributor

Pinging code owners for receiver/solace: @djaglowski @mcardy. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@dmitryax dmitryax mentioned this issue Dec 22, 2022
Merged
@mcardy mcardy mentioned this issue Dec 22, 2022
Merged
@dmitryax
Copy link
Member Author

@mcardy looks like it's still failing on main. Please see https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/3760209755/jobs/6390667040

@dmitryax dmitryax reopened this Dec 22, 2022
@mcardy
Copy link
Contributor

mcardy commented Dec 22, 2022

Wow looks like its very slow. I wonder why windows is so slow. I ran it about 100 times on my own windows machine and it seemed fine with the fix. I'll open a PR to up the timeout even more/investigate alternatives.

@dmitryax
Copy link
Member Author

Fixed by #17204

@dmitryax
Copy link
Member Author

@mcardy It's still happening occasionally https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/3976471954/jobs/6816975722

Maybe we should increase the timeout for windows to 1 second?

@codeboten
Copy link
Contributor

Happened again here, re-opening

@codeboten codeboten reopened this Feb 7, 2023
@atoulme atoulme added the flaky test a test is flaky label Mar 12, 2023
@mcardy
Copy link
Contributor

mcardy commented Mar 27, 2023 •
edited
Loading

Looking at this again, this is a different test failing than the original one reported. This is addressed with #19409

@mcardy mcardy mentioned this issue Mar 27, 2023
Merged
@dmitryax
Copy link
Member Author

Should be resolved by #20348

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working flaky test a test is flaky priority:p2 Medium receiver/solace
Projects
None yet
Milestone
No milestone
4 participants
@atoulme @codeboten @mcardy @dmitryax