Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pkg/ottl] Update contexts to properly handle map values in attributes #16337

Closed
TylerHelmuth opened this issue Nov 16, 2022 · 0 comments · Fixed by #16352
Closed

[pkg/ottl] Update contexts to properly handle map values in attributes #16337

TylerHelmuth opened this issue Nov 16, 2022 · 0 comments · Fixed by #16352
Assignees
@TylerHelmuth
Labels
enhancement New feature or request pkg/ottl priority:p3 Lowest

Comments

@TylerHelmuth
Copy link
Member

TylerHelmuth commented Nov 16, 2022 •
edited
Loading

Component(s)

pkg/ottl

Is your feature request related to a problem? Please describe.

Currently the OTTL contexts do not know how to support maps in attributes

opentelemetry-collector-contrib/pkg/ottl/contexts/internal/ottlcommon/value.go

Line 89 in f36fd9d

// TODO(anuraaga): Support set of map type.

This doesn't cause many problems today, but may cause issues when we start handling more complex log parsing.

Describe the solution you'd like

OTTL contexts know how to set a map attribute type.
@TylerHelmuth TylerHelmuth added enhancement New feature or request needs triage New item requiring triage help wanted Extra attention is needed good first issue Good for newcomers priority:p3 Lowest pkg/ottl and removed needs triage New item requiring triage labels Nov 16, 2022
@TylerHelmuth TylerHelmuth mentioned this issue Nov 17, 2022
Closed
@TylerHelmuth TylerHelmuth removed help wanted Extra attention is needed good first issue Good for newcomers labels Nov 17, 2022
@TylerHelmuth TylerHelmuth self-assigned this Nov 17, 2022
@TylerHelmuth TylerHelmuth mentioned this issue Nov 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TylerHelmuth TylerHelmuth

Labels
enhancement New feature or request pkg/ottl priority:p3 Lowest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[pkg/ottl] Add support for setting maps in Values TylerHelmuth/opentelemetry-collector-contrib
1 participant
@TylerHelmuth