Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename s3mapprovider to s3provider #14616

Closed
neelayu opened this issue Sep 30, 2022 · 0 comments
Closed

Rename s3mapprovider to s3provider #14616

neelayu opened this issue Sep 30, 2022 · 0 comments
Assignees
@neelayu
Labels
enhancement New feature or request

Comments

@neelayu
Copy link
Contributor

neelayu commented Sep 30, 2022

Describe the issue you're reporting

s3mapprovider was merged very recently. It is indeed a great addition to the repo. However, it should be renamed to s3provider keeping it consistent with the other providers from the core repo(ex: fileprovider, yamlprovider, envprovider, httpprovider)
@neelayu neelayu added the needs triage New item requiring triage label Sep 30, 2022
@neelayu neelayu mentioned this issue Sep 30, 2022
Merged
@evan-bradley evan-bradley added enhancement New feature or request and removed needs triage New item requiring triage labels Sep 30, 2022
@neelayu neelayu closed this as completed Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neelayu neelayu

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@evan-bradley @neelayu