-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
k8sattributes processor - Allow metadata extractions to be null #14452
Comments
Pinging code owners: @owais @dmitryax. See Adding Labels via Comments if you do not have permissions to add labels yourself. |
I am going to fix this bug after merging the PR. setting of metadata to null or empty value in the config will cleanup default metadata values. |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners: See Adding Labels via Comments if you do not have permissions to add labels yourself. |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
Requires open-telemetry/opentelemetry-collector#4001 to be resolved first |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
open-telemetry/opentelemetry-collector#8017 resolve this problem |
core will be updated in this pr |
…#27185) **Description:** Allow metadata extractions to be empty list After this is merged, user is allow to specify the metadata to be empty list like following ``` processors: k8sattributes: extract: annotations: - from: pod key: workload tag_name: k8s.annotations.workload labels: - from: pod key: app tag_name: k8s.labels.app metadata: [] ``` **Link to tracking Issue:** fix #14452 --------- Signed-off-by: Ziqi Zhao <[email protected]> Co-authored-by: Dmitrii Anoshin <[email protected]>
…open-telemetry#27185) **Description:** Allow metadata extractions to be empty list After this is merged, user is allow to specify the metadata to be empty list like following ``` processors: k8sattributes: extract: annotations: - from: pod key: workload tag_name: k8s.annotations.workload labels: - from: pod key: app tag_name: k8s.labels.app metadata: [] ``` **Link to tracking Issue:** fix open-telemetry#14452 --------- Signed-off-by: Ziqi Zhao <[email protected]> Co-authored-by: Dmitrii Anoshin <[email protected]>
Is your feature request related to a problem? Please describe.
I'd like to extract annotations and not be required to extract metadata fields as well.
Describe the solution you'd like
Allow me to set
metadata: null
or something similarDescribe alternatives you've considered
As a workaround I'm setting metadata to a field that my pod assocation rule is using
Additional context
opentelemetry-collector-contrib/processor/k8sattributesprocessor/options.go
Line 73 in bc9e9ba
The text was updated successfully, but these errors were encountered: