[receiver/hostmetrics] Error while fetching partitions on Windows invalidates receiving file system information

[atoulme]

What happened?

Description

The hostmetrics-> filesystems scraper is failing with this error

1.6615175914398837e+09	error	scraperhelper/scrapercontroller.go:197	Error scraping metrics	{"kind": "receiver", "name": "hostmetrics", "pipeline": "metrics", "error": "This drive is locked by BitLocker Drive Encryption. You must unlock this drive from Control Panel.", "scraper": "filesystem"}
go.opentelemetry.io/collector/receiver/scraperhelper.(*controller).scrapeMetricsAndReport
	/builds/o11y-gdi/splunk-otel-collector-releaser/.go/pkg/mod/go.opentelemetry.io/[email protected]/receiver/scraperhelper/scrapercontroller.go:197
go.opentelemetry.io/collector/receiver/scraperhelper.(*controller).startScraping.func1
	/builds/o11y-gdi/splunk-otel-collector-releaser/.go/pkg/mod/go.opentelemetry.io/[email protected]/receiver/scraperhelper/scrapercontroller.go:172

We do not care about metrics for this locked drive, but this error is preventing other drives from getting scraped.

The error is thrown when we tried to get the list of partitions at https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/receiver/hostmetricsreceiver/internal/scraper/filesystemscraper/filesystem_scraper.go#L80.

User tried to exclude the driver, but the problem is that those filters are applied after we get the partitions https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/receiver/hostmetricsreceiver/internal/scraper/filesystemscraper/filesystem_scraper.go#L88.

The PartitionsWithContextfunc on windows gopsutil/disk_windows.go stops on error and returns the list of partitions already collected and an error; so even if our scraper processed the partitions that are already collected and ignored the error, there is no guarantee that we’ll cover all partitions.

I have opened shirou/gopsutil#1347 to fix the issue from gopsutil.

Steps to Reproduce

• Set up a Windows machine
• Lock a drive
• Use the hostmetrics receiver with this machine

Expected Result

• All readable partitions should report in

Actual Result

• No partitions are reporting.

Collector version

0.59.0

Environment information

Environment

OS: Windows

OpenTelemetry Collector configuration

No response

Log output

No response

Additional context

No response

[github-actions]

Pinging code owners: @dmitryax. See Adding Labels via Comments if you do not have permissions to add labels yourself.

[atoulme]

The behavior of the collector, coupled with the new release of gopsutil, should now fix the issue. I will mark this closed and I look forward to the next release of the collector.