From d50e094b89ff6b5db1ad84dc855d6901ef1b2fc7 Mon Sep 17 00:00:00 2001 From: Paulin Todev Date: Tue, 24 Oct 2023 13:05:51 +0100 Subject: [PATCH] [headerssetter] Remove "Limitations" section from README. (#27465) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The docs for the `headers_setter` extension state that the `from_context` config option does not work if the batch processor is used. I believe this comment is out of date, because it seems that the [PR](https://github.com/open-telemetry/opentelemetry-collector/pull/7578) linked to the [issue](https://github.com/open-telemetry/opentelemetry-collector/issues/4544) has been merged. Note that I haven't tested that this actually works with the header setter extension. Please let me know if you think testing is necessary. Co-authored-by: Juraci Paixão Kröhling --- extension/headerssetterextension/README.md | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/extension/headerssetterextension/README.md b/extension/headerssetterextension/README.md index 73c8203eec10..3b0f1f5701b1 100644 --- a/extension/headerssetterextension/README.md +++ b/extension/headerssetterextension/README.md @@ -88,15 +88,8 @@ service: exporters: [ loki ] ``` -## Limitations - -At the moment, it is not possible to use the `from_context` option to ge the -header value if Collector's pipeline contains the batch processor. See [#4544]. - - [alpha]: https://github.com/open-telemetry/opentelemetry-collector#alpha [contrib]: https://github.com/open-telemetry/opentelemetry-collector-releases/tree/main/distributions/otelcol-contrib [Mimir]: https://grafana.com/oss/mimir/ [Tempo]: https://grafana.com/oss/tempo/ -[Loki]: https://grafana.com/oss/loki/ -[#4544]: https://github.com/open-telemetry/opentelemetry-collector/issues/4544 +[Loki]: https://grafana.com/oss/loki/ \ No newline at end of file