From 8062bf8c7dfd72b4ebb74f5bfdc713ab7047568f Mon Sep 17 00:00:00 2001 From: Carson Ip Date: Wed, 28 Feb 2024 06:49:42 +0800 Subject: [PATCH] telemetrygen: Fix incorrect error in log line (#31362) **Description:** Incorrect error is used in logger.Error within telemetrygen traces. --- .../telemetrygen-fix-log-incorrect-error.yaml | 27 +++++++++++++++++++ cmd/telemetrygen/internal/traces/traces.go | 2 +- 2 files changed, 28 insertions(+), 1 deletion(-) create mode 100644 .chloggen/telemetrygen-fix-log-incorrect-error.yaml diff --git a/.chloggen/telemetrygen-fix-log-incorrect-error.yaml b/.chloggen/telemetrygen-fix-log-incorrect-error.yaml new file mode 100644 index 000000000000..bddd0037fe0f --- /dev/null +++ b/.chloggen/telemetrygen-fix-log-incorrect-error.yaml @@ -0,0 +1,27 @@ +# Use this changelog template to create an entry for release notes. + +# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' +change_type: bug_fix + +# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver) +component: cmd/telemetrygen + +# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). +note: Fix incorrect error logged in traces batch span processor shutdown + +# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists. +issues: [31362] + +# (Optional) One or more lines of additional information to render under the primary note. +# These lines will be padded with 2 spaces and then inserted directly into the document. +# Use pipe (|) for multiline entries. +subtext: + +# If your change doesn't affect end users or the exported elements of any package, +# you should instead start your pull request title with [chore] or use the "Skip Changelog" label. +# Optional: The change log or logs in which this entry should be included. +# e.g. '[user]' or '[user, api]' +# Include 'user' if the change is relevant to end users. +# Include 'api' if there is a change to a library API. +# Default: '[user]' +change_logs: [] diff --git a/cmd/telemetrygen/internal/traces/traces.go b/cmd/telemetrygen/internal/traces/traces.go index 5f3529253cf1..02817577b915 100644 --- a/cmd/telemetrygen/internal/traces/traces.go +++ b/cmd/telemetrygen/internal/traces/traces.go @@ -73,7 +73,7 @@ func Start(cfg *Config) error { defer func() { logger.Info("stop the batch span processor") if tempError := ssp.Shutdown(context.Background()); tempError != nil { - logger.Error("failed to stop the batch span processor", zap.Error(err)) + logger.Error("failed to stop the batch span processor", zap.Error(tempError)) } }() }