Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable AndroidLifecycleInstrumentation by default #337

Closed
breedx-splk opened this issue May 3, 2024 · 2 comments
Closed

Enable AndroidLifecycleInstrumentation by default #337

breedx-splk opened this issue May 3, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@breedx-splk
Copy link
Contributor

The AndroidLifecycleInstrumentation is not enabled by default, and I think that's a mistake. This instrumentation helps to report startup time and also makes available the name of the "current screen" so that it can be added as an attribute on other data (spans/events).

This can/should probably wait until the changes that @LikeTheSalad is proposing around the instrumentation API have settled a little big, but I feel like most users definitely want this instrumentation turned on by default.
@breedx-splk breedx-splk added the enhancement New feature or request label May 3, 2024
@LikeTheSalad
Copy link
Contributor

I think this should be the case now.

@breedx-splk
Copy link
Contributor Author

Yeah, using the demo app I was able to confirm that both the ActivityLifecycleInstrumentation and the FragmentLifecycleInstrumentation are being installed...and although we don't have any Fragments currently, the activity instrumentation seems to be working and putting the appropriate events on the activity lifecycle spans:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LikeTheSalad @breedx-splk