Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename transaction #325

Open
baudouxbenjamin opened this issue Apr 26, 2024 · 4 comments
Open

Rename transaction #325

baudouxbenjamin opened this issue Apr 26, 2024 · 4 comments

Comments

@baudouxbenjamin
Copy link

Hello,

We're using elastic on Android and for now every transactions are under something like GET, POST, etc.
I'd like to rename my transactions to GET my-service.be/data for example to make it easier to find.

Is it possible? If not, is it planned in a future release?

Thanks!

@breedx-splk
Copy link
Contributor

Hi @baudouxbenjamin . The names of the spans generated by this instrumentation should comply with the OpenTelemetry HTTP semantic conventions.

If you check that link, you'll see that the guidance for client http spans is:

HTTP client spans have no http.route attribute since client-side instrumentation is not generally aware of the “route”, and therefore HTTP client span names SHOULD be {method}.

So I don't think we have any real intention to change this. You can always put manual instrumentation around these call sites, if you'd like to get more details in the name.

@breedx-splk breedx-splk added the needs author feedback Waiting for additional feedback from the author label Apr 26, 2024
@LikeTheSalad
Copy link
Contributor

I agree we should stick to the semconv, however, it does mention that we could add the HTTP route (if we knew what it was) though we don't know, so it makes sense we don't do it and I don't think OTel Android should try to make any "smart" decisions on what the HTTP route should look like.

Still, I think we could at least provide some APIs to allow users to add the route themselves, maybe in a similar fashion to what someone's suggested doing for screen names.

Copy link

This has been automatically marked as stale because it has been marked as needing author feedback and has not had any activity for 21 days. It will be closed automatically if there is no response from the author within 14 additional days from this comment.

@github-actions github-actions bot added the stale label May 20, 2024
@LikeTheSalad
Copy link
Contributor

There has been some progress around this issue in the Java SIG and also here. I'm planning to add a config option for it soon.

@LikeTheSalad LikeTheSalad removed stale needs author feedback Waiting for additional feedback from the author labels May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants