Add ability to report general errors in PackageStatuses #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PackageStatuses previously only allowed reporting errors per package. However, sometime errors can happen when trying to apply the offered PackageAvailable message, but the error is not related to any particular package. There is currently no way to report such errors. This adds ability to report general errors via error_message field in PackageStatuses. Resolves open-telemetry#82
pmm-sumo
approved these changes
May 24, 2022
tigrannajaryan
added a commit
to tigrannajaryan/opamp-go
that referenced
this pull request
May 25, 2022
PackageStatuses previously only allowed reporting errors per package. However, sometime errors can happen when trying to apply the offered PackageAvailable message, but the error is not related to any particular package. There was no way to report such errors. This adds ability to report general errors via error_message field in PackageStatuses. Implements spec change open-telemetry/opamp-spec#83
tigrannajaryan
added a commit
to open-telemetry/opamp-go
that referenced
this pull request
May 25, 2022
PackageStatuses previously only allowed reporting errors per package. However, sometime errors can happen when trying to apply the offered PackageAvailable message, but the error is not related to any particular package. There was no way to report such errors. This adds ability to report general errors via error_message field in PackageStatuses. Implements spec change open-telemetry/opamp-spec#83
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PackageStatuses previously only allowed reporting errors per package.
However, sometime errors can happen when trying to apply the offered PackageAvailable message, but the error is not related to any particular package. There is currently no way to report such errors.
This adds ability to report general errors via error_message field in PackageStatuses.
Resolves #82