From 695da19aca92c391aef17a6f859f555fd2a2bb9f Mon Sep 17 00:00:00 2001 From: Jakub Skiba <94470482+jskiba@users.noreply.github.com> Date: Wed, 22 May 2024 16:50:35 +0200 Subject: [PATCH 1/4] * fix typo --- proto/opamp.proto | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/proto/opamp.proto b/proto/opamp.proto index e78b35e..3721f84 100644 --- a/proto/opamp.proto +++ b/proto/opamp.proto @@ -564,7 +564,7 @@ message AgentDescription { // Agent type, e.g. "io.opentelemetry.collector" // - service.namespace if it is used in the environment where the Agent runs. // - service.version should be set to version number of the Agent build. - // - service.instance.id should be set. It may be be set equal to the Agent's + // - service.instance.id should be set. It may be set equal to the Agent's // instance uid (equal to ServerToAgent.instance_uid field) or any other value // that uniquely identifies the Agent in combination with other attributes. // - any other attributes that are necessary for uniquely identifying the Agent's From 01394713d4660eb8000d2a6f86cabd29637b04f9 Mon Sep 17 00:00:00 2001 From: Jakub Skiba <94470482+jskiba@users.noreply.github.com> Date: Wed, 22 May 2024 16:53:13 +0200 Subject: [PATCH 2/4] * undo --- proto/opamp.proto | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/proto/opamp.proto b/proto/opamp.proto index 3721f84..e78b35e 100644 --- a/proto/opamp.proto +++ b/proto/opamp.proto @@ -564,7 +564,7 @@ message AgentDescription { // Agent type, e.g. "io.opentelemetry.collector" // - service.namespace if it is used in the environment where the Agent runs. // - service.version should be set to version number of the Agent build. - // - service.instance.id should be set. It may be set equal to the Agent's + // - service.instance.id should be set. It may be be set equal to the Agent's // instance uid (equal to ServerToAgent.instance_uid field) or any other value // that uniquely identifies the Agent in combination with other attributes. // - any other attributes that are necessary for uniquely identifying the Agent's From c0aad6907b43522e8a83cb39f9d5ef6909824a7c Mon Sep 17 00:00:00 2001 From: Jakub Skiba <94470482+jskiba@users.noreply.github.com> Date: Wed, 22 May 2024 16:53:35 +0200 Subject: [PATCH 3/4] * fix typo --- specification.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification.md b/specification.md index 88213e0..c4659e7 100644 --- a/specification.md +++ b/specification.md @@ -1108,7 +1108,7 @@ attributes SHOULD be specified: - service.name should be set to the same value that the Agent uses in its own telemetry. - service.namespace if it is used in the environment where the Agent runs. - service.version should be set to version number of the Agent build. -- service.instance.id should be set. It may be be set equal to the Agent's +- service.instance.id should be set. It may be set equal to the Agent's instance uid (equal to ServerToAgent.instance_uid field) or any other value that uniquely identifies the Agent in combination with other attributes. - any other attributes that are necessary for uniquely identifying the Agent's From 7c37f77b8dd78137eb2fa70342123b3418d150c9 Mon Sep 17 00:00:00 2001 From: Jakub Skiba <94470482+jskiba@users.noreply.github.com> Date: Wed, 22 May 2024 17:02:24 +0200 Subject: [PATCH 4/4] * fix typo --- proto/opamp.proto | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/proto/opamp.proto b/proto/opamp.proto index e78b35e..3721f84 100644 --- a/proto/opamp.proto +++ b/proto/opamp.proto @@ -564,7 +564,7 @@ message AgentDescription { // Agent type, e.g. "io.opentelemetry.collector" // - service.namespace if it is used in the environment where the Agent runs. // - service.version should be set to version number of the Agent build. - // - service.instance.id should be set. It may be be set equal to the Agent's + // - service.instance.id should be set. It may be set equal to the Agent's // instance uid (equal to ServerToAgent.instance_uid field) or any other value // that uniquely identifies the Agent in combination with other attributes. // - any other attributes that are necessary for uniquely identifying the Agent's