From aaace74bba68aeecdf6fc34c8b9ce91e7d3e1f6c Mon Sep 17 00:00:00 2001 From: Tigran Najaryan <4194920+tigrannajaryan@users.noreply.github.com> Date: Mon, 17 Oct 2022 16:50:51 -0400 Subject: [PATCH] Remove unnecessary recommendation about service.name (#135) Contributes to https://github.com/open-telemetry/opamp-spec/issues/131 service.name is an existing OpenTelemetry convention. OpAMP is not in the business of defining OpenTelemetry's semantic conventions. I deleted the unnecessary wording that tried to add more meaning to the service.name that is not our business to do. --- specification.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/specification.md b/specification.md index f1a68d1..7f55e3f 100644 --- a/specification.md +++ b/specification.md @@ -948,8 +948,7 @@ https://github.com/open-telemetry/opentelemetry-specification/tree/main/specific For standalone running Agents (such as OpenTelemetry Collector) the following attributes SHOULD be specified: -- service.name should be set to a reverse FQDN that uniquely identifies the - Agent type, e.g. "io.opentelemetry.collector" +- service.name should be set to the same value that the Agent uses in its own telemetry. - service.namespace if it is used in the environment where the Agent runs. - service.version should be set to version number of the Agent build. - service.instance.id should be set. It may be be set equal to the Agent's