Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Semantic convention generator adds more than one blank line, failing mdlint #47

Closed
Oberon00 opened this issue Jun 15, 2021 · 3 comments · Fixed by #48
Closed

Semantic convention generator adds more than one blank line, failing mdlint #47

Oberon00 opened this issue Jun 15, 2021 · 3 comments · Fixed by #48
Labels
bug Something isn't working semconv/md Related specifically to the markdown output of the semantic convention generator semconv Related to the semantic convention generator.

Comments

@Oberon00
Copy link
Member

See open-telemetry/opentelemetry-specification#1759 (comment)

The PR in question has two enums in a single convention, and the first one has a note on one of the members. As a result, two consecutive newlines are printed between the footnote and the next enum table.
@Oberon00 Oberon00 added bug Something isn't working semconv Related to the semantic convention generator. semconv/md Related specifically to the markdown output of the semantic convention generator labels Jun 15, 2021
@Oberon00 Oberon00 mentioned this issue Jun 15, 2021
Merged
@bryce-b
Copy link
Member

bryce-b commented Jun 17, 2021

I can take this ticket, but I don't think i'll be able to get a PR in until next week

@Oberon00
Copy link
Member Author

Just comment on the ticket if/when you start working on it.

@bryce-b
Copy link
Member

bryce-b commented Jun 17, 2021

I'm working on it now, but I'm doing a half day today and I'm OOF tomorrow.

@bryce-b bryce-b mentioned this issue Jun 21, 2021
Merged
@arminru arminru linked a pull request Jun 22, 2021 that will close this issue
Fixes #47 multiple lines added in table generation #48
Merged
arminru pushed a commit that referenced this issue Jun 22, 2021
@bryce-b
Fixes #47 multiple lines added in table generation (#48)
c7067fa
@Oberon00 Oberon00 mentioned this issue Jul 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working semconv/md Related specifically to the markdown output of the semantic convention generator semconv Related to the semantic convention generator.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #47 multiple lines added in table generation bryce-b/build-tools
2 participants
@Oberon00 @bryce-b