From 3c4f7a70b15e61e076dc28843eb68079c2db049a Mon Sep 17 00:00:00 2001
From: David Ashpole <dashpole@google.com>
Date: Tue, 2 Aug 2022 14:53:12 +0000
Subject: [PATCH] improve scope test

---
 semantic-conventions/src/tests/data/yaml/scope.yaml        | 5 +++--
 .../src/tests/semconv/model/test_correct_parse.py          | 7 ++++---
 2 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/semantic-conventions/src/tests/data/yaml/scope.yaml b/semantic-conventions/src/tests/data/yaml/scope.yaml
index 85605e27..7cc8a3ef 100644
--- a/semantic-conventions/src/tests/data/yaml/scope.yaml
+++ b/semantic-conventions/src/tests/data/yaml/scope.yaml
@@ -1,6 +1,7 @@
 groups:
-  - id: scope
-    prefix: scope
+  - id: scope-id
+    prefix: scopeprefix
+    type: scope
     brief: >
       Instrumentation Scope attributes
     attributes:
diff --git a/semantic-conventions/src/tests/semconv/model/test_correct_parse.py b/semantic-conventions/src/tests/semconv/model/test_correct_parse.py
index 94ef0dd9..a77a8673 100644
--- a/semantic-conventions/src/tests/semconv/model/test_correct_parse.py
+++ b/semantic-conventions/src/tests/semconv/model/test_correct_parse.py
@@ -675,13 +675,14 @@ def test_scope_attribute(self):
         self.assertEqual(len(semconv.models), 1)
 
         expected = {
-            "id": "scope",
-            "prefix": "scope",
+            "id": "scope-id",
+            "prefix": "scopeprefix",
+            "type": "scope",
             "extends": "",
             "brief": "Instrumentation Scope attributes",
             "n_constraints": 0,
             "attributes": [
-                "scope.short_name",
+                "scopeprefix.short_name",
             ],
         }
         self.semantic_convention_check(list(semconv.models.values())[0], expected)