Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add modifiers #379

Closed
wants to merge 11 commits into from
Closed

Add modifiers #379

wants to merge 11 commits into from

Conversation

markaren
Copy link
Contributor

@markaren markaren commented Sep 21, 2019

This PR allows any number of modifiers to be added to a scalar_connection.
A gain_modifier has been implemented.

auto con = std::make_shared<cse::scalar_connection>(out, in);
con ->add_modifer(std::make_shared<cse::gain_modifier>(2));

Happy to receive feedback.

Let me know if this is wanted or not. Perhaps you guys have envisioned another way of achieving the same. Then please share :)

Note: I think modifiers should have access to currentTime and deltaTime. E.g. in order to implement filters and or condition based modifiers.

Resolves #378

@markaren markaren mentioned this pull request Sep 22, 2019
@markaren
Copy link
Contributor Author

Closing as we agree that modifiers are better to have on inputs/outputs

@markaren markaren closed this Sep 24, 2019
@markaren markaren deleted the feature/modifier branch September 24, 2019 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Signal modifiers
1 participant