-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #369 - C API: default startTime in SSP will always be overriden #370
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. cse-server-go needs a companion PR.
@@ -152,6 +152,7 @@ cse_execution* cse_execution_create( | |||
*/ | |||
cse_execution* cse_ssp_execution_create( | |||
const char* sspDir, | |||
bool startTimeDefined, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
startTimeDefined
should be documented above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some doc. See if it sounds OK.
Closed in favor of #373 |
Closes #369
Blocks #368