Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #369 - C API: default startTime in SSP will always be overriden #370

Closed
wants to merge 5 commits into from

Conversation

markaren
Copy link
Contributor

@markaren markaren commented Sep 13, 2019

Closes #369
Blocks #368

@markaren markaren changed the title Fix #369 Fix #369 - C API: default startTime will always be overriden Sep 13, 2019
@markaren markaren changed the title Fix #369 - C API: default startTime will always be overriden Fix #369 - C API: default startTime in SSP will always be overriden Sep 13, 2019
Copy link
Member

@eidekrist eidekrist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. cse-server-go needs a companion PR.

@@ -152,6 +152,7 @@ cse_execution* cse_execution_create(
*/
cse_execution* cse_ssp_execution_create(
const char* sspDir,
bool startTimeDefined,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

startTimeDefined should be documented above.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some doc. See if it sounds OK.

@markaren
Copy link
Contributor Author

Closed in favor of #373

@markaren markaren closed this Sep 17, 2019
@markaren markaren deleted the bugfix/369-ssp-overrides-starttime branch September 17, 2019 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loading SSP from C API overrides default startTime
2 participants