Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory leak observed when using file_observer or time_series_observer #646

Closed
restenb opened this issue Aug 18, 2021 · 2 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@restenb
Copy link
Member

restenb commented Aug 18, 2021

When using the file observer or unbuffered time series observer, memory use of the library is explosive over time. The issue is especially apparent when running a simulation with both, indicating that both these observers have separate memory leak problems.

@restenb restenb self-assigned this Aug 18, 2021
@restenb restenb added the bug Something isn't working label Aug 18, 2021
@kyllingstad
Copy link
Member

For time_series_observer, the problem seems to be that when we say "unbuffered" we really mean "unlimited buffer size". ;)

Regarding file_observer, I suspect that the ss_ buffer never gets emptied and keeps growing (unlike the raw data buffers – xxxSamples_ – which get cleared manually). A quick test/fix would be to turn ss_ into a local variable inside persist() instead and see if that improves things.

@kyllingstad
Copy link
Member

Fixed by #647.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants