-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable overridable master algorithm selection for SSP #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 17, 2019
Two new tests added. |
eidekrist
approved these changes
Sep 17, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If accepted, this PR will replace #368, and will close #362 in the process.
It also replaces #370. It's easier to do both at once and will close #369
Instead of completely removing the custom annotation, it can function as a optional fallback similar to how
defaultExperiment
works in SSP and FMI.The C++ API stays backwards compatible. The C API now requires 1 additional arguments for the
cse_ssp_execution_create
function, allowing thestartTime
defined within the ssp to be optinally used. Otherwise this will function as before.A new function called
cse_ssp_fixed_step_execution_create
that takes 4 arguments is also introduced. This function allows the user to assign a customstepSize
value for the algoriithm. In the future this function should be replaced with a generic function taking acse_algorithm
pointer as argument instead. But that`s future work whencse
ships with more than one master algorithm.This PR should make everyone happy, happy, happy. Please have a look at the updated C API doc for the aforementioned function to see if it sounds ok though ..
It should also fix #338, as this PR makes the
osp:FixedStepMaster
element optional.