Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename cse::variable_index #265 #339

Merged
merged 3 commits into from
Aug 28, 2019
Merged

Rename cse::variable_index #265 #339

merged 3 commits into from
Aug 28, 2019

Conversation

markaren
Copy link
Contributor

Closes #265

@eidekrist
Copy link
Member

I've pushed a commit renaming local variables and methods. Hopefully I got it all. Will create a companion PR for cse-server-go.

kyllingstad
kyllingstad requested changes Aug 28, 2019
View reviewed changes
Copy link
Member

@kyllingstad kyllingstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, I had no idea how much we use that type. :D Good job!

In some places, "variable reference" is used instead of "value reference" in documentation and exception messages, which is slightly inconsistent and potentially confusing. (Probably no worse than before, but this would seem like a good opportunity to fix it. ;)

include/cse.h Outdated Show resolved Hide resolved
include/cse/observer/time_series_provider.hpp Outdated Show resolved Hide resolved
src/c/cse.cpp Outdated Show resolved Hide resolved
src/c/cse.cpp Outdated Show resolved Hide resolved
src/cpp/cse/slave_simulator.hpp Outdated Show resolved Hide resolved
kyllingstad
kyllingstad approved these changes Aug 28, 2019
View reviewed changes
Copy link
Member

@kyllingstad kyllingstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, LGTM!

@eidekrist eidekrist merged commit 844836c into master Aug 28, 2019
@eidekrist eidekrist deleted the rename-variable-index branch August 28, 2019 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyllingstad kyllingstad kyllingstad approved these changes

@ljamt ljamt Awaiting requested review from ljamt

@eidekrist eidekrist Awaiting requested review from eidekrist

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename cse::variable_index
3 participants
@markaren @eidekrist @kyllingstad