Feature/212 provide overview of modified variables #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…modified-variables' into feature/212-provide-overview-of-modified-variables
…s of the same index
…ariables # Conflicts: # include/cse/execution.hpp # src/cpp/execution.cpp
added 2 commits
July 9, 2019 12:50
eidekrist
reviewed
Jul 12, 2019
eidekrist
requested changes
Jul 12, 2019
Co-Authored-By: Kristoffer Eide <[email protected]>
Co-Authored-By: Kristoffer Eide <[email protected]>
Co-Authored-By: Kristoffer Eide <[email protected]>
Co-Authored-By: Kristoffer Eide <[email protected]>
Co-Authored-By: Kristoffer Eide <[email protected]>
Co-Authored-By: Kristoffer Eide <[email protected]>
Co-Authored-By: Kristoffer Eide <[email protected]>
Co-Authored-By: Kristoffer Eide <[email protected]>
Co-Authored-By: Kristoffer Eide <[email protected]>
Co-Authored-By: Kristoffer Eide <[email protected]>
Co-Authored-By: Kristoffer Eide <[email protected]>
Co-Authored-By: Kristoffer Eide <[email protected]>
Co-Authored-By: Kristoffer Eide <[email protected]>
Co-Authored-By: Kristoffer Eide <[email protected]>
Co-Authored-By: Kristoffer Eide <[email protected]>
…modified-variables' into feature/212-provide-overview-of-modified-variables
eidekrist
approved these changes
Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bit unsure who's currently on vacation and not, so review if you can.
This PR implements tracking of variables that currently have an active modifier in cse-core. The getters and setters for modifiers already present in
slave_simulator.cppare used to track/untrack avariable_indexwith internal sets. Theexecutioncan then be queried to return all currently manipulated variables in the simulation. Finally this is stuffed through the C API by transforming into a vector ofcse_variable_ids.Will only work with the companion PRs for cse-server-go and cse-client.