Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support on/off toggling of file observer #508

Closed
eidekrist opened this issue Jan 7, 2020 · 0 comments · Fixed by #509
Closed

Support on/off toggling of file observer #508

eidekrist opened this issue Jan 7, 2020 · 0 comments · Fixed by #509
Assignees
@eidekrist
Labels
enhancement New feature or request

Comments

@eidekrist
Copy link
Member

It would be very nice to be able to toggle file observation on or off mid simulation. DNV GL has a use case for this when running scenarios, where in the past it has proven beneficial to create separate log files for each scenario the user has run.
@eidekrist eidekrist added the enhancement New feature or request label Jan 7, 2020
@eidekrist eidekrist self-assigned this Jan 7, 2020
eidekrist added a commit that referenced this issue Jan 7, 2020
@eidekrist
#508 Support toggling file observer on or off.
409201e
eidekrist added a commit that referenced this issue Jan 7, 2020
@eidekrist
#508 Remove unused variable.
a1dfb2d
eidekrist added a commit that referenced this issue Jan 7, 2020
@eidekrist
#508 Remove superfluous value reference collections.
0e4b643
eidekrist added a commit that referenced this issue Jan 7, 2020
@eidekrist
#508 Ensure value writer is present.
0646a5b
@eidekrist eidekrist mentioned this issue Jan 7, 2020
Merged
eidekrist added a commit that referenced this issue Jan 13, 2020
@eidekrist
Support file observer on/off toggling (#509)
f467a9d 
* #508 Support toggling file observer on or off.

* #508 Remove unused variable.

* #508 Remove superfluous value reference collections.

* #508 Ensure value writer is present.

* Fix typo

* Add panic message

* find_variables_of_type() is obsolete. Consolidate usage of find_variables().

* Add concurrency support to file observer.

* Review follow-up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eidekrist eidekrist

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support file observer on/off toggling open-simulation-platform/libcosim
1 participant
@eidekrist