-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a persistent cache for FMU contents #30
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Should see an effect on the 90+GB cached directories on the Jenkins slaves :)
Closing for the time being. Will pick up again later. |
This is a new mandatory method in the observer interface.
Reopening now that open-simulation-platform/libcosim#388 is ready. |
Lots of changes since the approval was first given.
I just discovered that this PR had bitrotted. I've updated it now, so it's ready for a new review. It's a rather long-standing one, so it would be good to get it done. :) |
This PR looks good to me. I've also tested it functionally. The cached fmus end up in When running the dp-ship example or inspecting the OSOM.fmu, I notice that we still create a "cse_guid" folder in |
Weird, I can't reproduce this on my computer, neither on Windows nor Linux. Are you able to run |
Sorry. Debugging outdated code. Will come back with more accurate info |
It is inpect.cpp line 74: Could it be the |
Yes. That is as expected, and as long as the directory gets deleted again afterwards, it's not a bug. Thanks for checking! |
Fixes #11.
I've submitted a companion pull request for cse-core which must be merged first: open-simulation-platform/libcosim#388. Once that is accepted, I'll revert the channel change inconanfile.txt
here.