Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change base url for subdirectory #309

Merged
merged 7 commits into from
May 29, 2024
Merged

fix: Change base url for subdirectory #309

merged 7 commits into from
May 29, 2024

Conversation

BekahHW
Copy link
Member

@BekahHW BekahHW commented May 29, 2024

Description

Related Tickets & Documents

closes #307

Mobile & Desktop Screenshots/Recordings

Using the deploy preview in the next.config.js file works:

Screen.Recording.2024-05-29.at.1.01.27.PM.mov

Steps to QA

Tier (staff will fill in)

  • Tier 1
  • Tier 2
  • Tier 3
  • Tier 4

[optional] What gif best describes this PR or how it makes you feel?

@BekahHW BekahHW requested a review from a team as a code owner May 29, 2024 14:30
Copy link

netlify bot commented May 29, 2024

Deploy Preview for docs-open ready!

Name Link
🔨 Latest commit 760c462
🔍 Latest deploy log https://app.netlify.com/sites/docs-open/deploys/66575b64b95fea0009a26cf7
😎 Deploy Preview https://deploy-preview-309--docs-open.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@BekahHW BekahHW requested a review from nickytonline May 29, 2024 17:14
Copy link

netlify bot commented May 29, 2024

Deploy Preview for docs-open ready!

Name Link
🔨 Latest commit 12588c6
🔍 Latest deploy log https://app.netlify.com/sites/docs-open/deploys/665783e89a429c0008579c9e
😎 Deploy Preview https://deploy-preview-309--docs-open.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@nickytonline nickytonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@BekahHW BekahHW merged commit b243676 into main May 29, 2024
11 checks passed
@BekahHW BekahHW deleted the feat/testing branch May 29, 2024 19:45
github-actions bot pushed a commit that referenced this pull request May 29, 2024
### [1.75.3](v1.75.2...v1.75.3) (2024-05-29)

### Bug Fixes

* Change base url for subdirectory ([#309](#309)) ([b243676](b243676))
Copy link
Contributor

🎉 This PR is included in version 1.75.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request May 29, 2024
* Change base url

* Change url

* Fix config

* Change base url again

* Another try

* Add file to see if that fixes deploy

* Add env var for prod v. deploy b243676
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: make docs a subdirectory to landing-page
2 participants