Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: TypeError: Cannot read properties of undefined (reading 'split') after signing up to OpenSauced #3649

Closed
nickytonline opened this issue Jun 27, 2024 · 5 comments · Fixed by #3890
Assignees
Labels
🐛 bug Something isn't working core team work Work that the OpenSauced core team takes on high-priority Work on these issues first onboarding released on @beta released

Comments

@nickytonline
Copy link
Member

A user reported after signup a client-side crash.

image

It looks like a string is undefined somewhere. Looking at our codebase, it could be either trying to split a GitHub user's interests or it's a repo that is undefined trying to be split on /. I'm leaning more towards the GitHub interests being the issue without knowing exactly where this happened, but it is post signup.

@nickytonline nickytonline added 🐛 bug Something isn't working high-priority Work on these issues first core team work Work that the OpenSauced core team takes on onboarding labels Jun 27, 2024
Copy link
Contributor

Thanks for the issue, our team will look into it as soon as possible! If you would like to work on this issue, please wait for us to decide if it's ready. The issue will be ready to work on once we remove the "needs triage" label.

To claim an issue that does not have the "needs triage" label, please leave a comment that says ".take". If you have any questions, please comment on this issue.

For full info on how to contribute, please check out our contributors guide.

@jpmcb
Copy link
Member

jpmcb commented Jun 27, 2024

Mentioning this here as well:


Interests can definitely be EMPTY in the database which should get surfaced in the v2/users/{username} endpoint as "interests": "". So, this shouldn't be undefined.

Two questions:

  • Can we replicate this reliably with new test users?
  • Surprised this wasn't caught by Sentry since it throws in the client. Worth investigating why that might have been.

@nickytonline
Copy link
Member Author

As @jpmcb mentioned, odd that this wasn't caught by Sentry. We'lll need to see if this can be reproduced.

Copy link
Contributor

open-sauced bot commented Aug 9, 2024

🎉 This issue has been resolved in version 2.52.0-beta.12 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Copy link
Contributor

open-sauced bot commented Aug 9, 2024

🎉 This issue has been resolved in version 2.52.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@open-sauced open-sauced bot added the released label Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working core team work Work that the OpenSauced core team takes on high-priority Work on these issues first onboarding released on @beta released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants