fix: update user search to fallback to GitHub API on error and zero results #3569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Issue Reference
In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.
✅ Deploy Preview for design-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for oss-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jpmcb
approved these changes
Jun 17, 2024
open-sauced bot
pushed a commit
that referenced
this pull request
Jun 18, 2024
## [2.36.0](v2.35.0...v2.36.0) (2024-06-18) ### 🐛 Bug Fixes * Contributor Confidence styling ([#3572](#3572)) ([3e7c4ed](3e7c4ed)) * remove GitHub organization permissions request from authentication ([#3570](#3570)) ([673923c](673923c)) * update user search to fallback to GitHub API on error and zero results ([#3569](#3569)) ([a5946d0](a5946d0)) ### 🍕 Features * add contributions filter to contributor profile ([#3556](#3556)) ([f588f9d](f588f9d)) * add workspace layout to user page ([#3537](#3537)) ([2504c34](2504c34)) * enabled loading an existing conversation in StarSearch ([#3563](#3563)) ([cc34e7b](cc34e7b)) * now StarSearch uses the new StarSearch API endpoints for chat creation/updates ([#3565](#3565)) ([0ac0145](0ac0145)) * Repo Pages - move devstats to top of mobile view ([#3574](#3574)) ([658b76a](658b76a))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
falsewhich indicates no results were found in either.Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings
Steps to QA
Tier (staff will fill in)
[optional] What gif best describes this PR or how it makes you feel?