Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: we cant see the sidebars on small screens #1510

Closed
1 of 2 tasks
a0m0rajab opened this issue Aug 6, 2023 · 7 comments
Closed
1 of 2 tasks

Bug: we cant see the sidebars on small screens #1510

a0m0rajab opened this issue Aug 6, 2023 · 7 comments
Assignees
Labels
🎨 style Visual issues not impacting functionality
Milestone

Comments

@a0m0rajab
Copy link
Contributor

Describe the bug

If we go to small or medium screens, there is no way to see the side bars:

image

Steps to reproduce

  1. go to feed
  2. make the screen small or medium

Browsers

No response

Additional context (Is this in dev or production?)

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

Contributing Docs

  • I agree to follow this project's Contribution Docs
@a0m0rajab a0m0rajab added 🐛 bug Something isn't working 👀 needs triage labels Aug 6, 2023
@brandonroberts brandonroberts added 🎨 style Visual issues not impacting functionality and removed 🐛 bug Something isn't working 👀 needs triage labels Aug 7, 2023
@brandonroberts brandonroberts added this to the Papercuts milestone Aug 7, 2023
@babblebey
Copy link
Contributor

The Sidebar had intentionally been hidden for Responsiveness purposes, and it was further worked on with the PR #1490

Are you suggesting that we should still look for a way to factor it into display on mobile!?

I could be all in for this idea too, but this is if we're looking to factor in display for the HighlightFilter component, because it's the only component looking like it's imperative.

We could look to implement a Side Navigation to hold this and show it onClick a trigger..

Though the Right sidebar is non-imperative IMHO and we needn't cluster the very small mobile viewport with an extra option but maybe everything can fit into the Side Navigate from top of bottom, that way we are still able to keep the Newsletter component too (it may look imperative).

@nightknighto
Copy link
Contributor

@bdougie @brandonroberts
any updates on the status of this issue? Is it ready to be taken on?
also is there a design available for this, or shall I suggest a design?

My suggestion would be to add this part to the mobile view:
image
as well as the Repositories filter, before the highlights list

@bdougie
Copy link
Member

bdougie commented Oct 22, 2023

There is no design but fine to see your interpretation. Radix and Headless UI not have an options.

The List feature also has a drawers designed for filtering.

cc @open-sauced/design

@nightknighto
Copy link
Contributor

.take

@nightknighto
Copy link
Contributor

currently the repo list is shown like this:
msedge_bn3r00L9g3

For small screens, this takes too much space and so it will be like this for them:
msedge_RThMYvFlcD

How about making this the default for all screen sizes? It looks much better like this IMHO @bdougie

@bdougie
Copy link
Member

bdougie commented Oct 23, 2023

@open-sauced/design for feedback

@brandonroberts
Copy link
Contributor

Will revisit when we refresh the feed page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 style Visual issues not impacting functionality
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

5 participants