Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add Conditional Routing for Single Highlight Dialog Close Button #1414

Closed
2 tasks done
babblebey opened this issue Jul 24, 2023 · 4 comments · Fixed by #1473
Closed
2 tasks done

Feature: Add Conditional Routing for Single Highlight Dialog Close Button #1414

babblebey opened this issue Jul 24, 2023 · 4 comments · Fixed by #1473

Comments

@babblebey
Copy link
Contributor

babblebey commented Jul 24, 2023

Description

Currently, when a user clicks on a single highlight from a user profile, a dialog opens on the /feed/[id] route. However, when the user clicks on the close button of the dialog, it routes back to the /feed page, displaying the general highlights. This behavior can be confusing and requires the user to go back to the user profile page again to view their highlights.

To enhance the user experience, I propose adding a conditional routing feature to the close button of the dialog. The idea is to route to the /feed page only when the dialog is opened from the /feed page. If the dialog is opened from a user profile page, the close button should simply close the dialog without any additional routing.

Steps to reproduce

  1. Go to the a user profile highlights page (user/[username]/highlights) where a list of their highlights is displayed.
  2. Click on one of the highlights to view more details. Notice that a dialog opens showing additional information about the selected highlight.
  3. In the dialog, you can see the close button (usually represented by an 'X' or a close icon).
  4. Click on the close button in the dialog.
  5. Observe that the page navigates back to the main highlights page (/feed) instead of staying/returning to the user's profile page if the dialog was opened from there.

Expected Behavior:

When clicking the close button in the dialog, it should close the dialog and return to the user's profile page if the dialog was opened from there. However, if the dialog was opened from the main highlights page, clicking the close button should navigate back to the main highlights page (/feed).

screencast-insights.opensauced.pizza-2023.07.14-13_53_47.webm

Browsers

Chrome, Firefox, Safari, Edge, Opera

Additional context (Is this in dev or production?)

Dev and Production

Code of Conduct

  • I agree to follow this project's Code of Conduct

Contributing Docs

  • I agree to follow this project's Contribution Docs
@babblebey babblebey added 🐛 bug Something isn't working 👀 needs triage labels Jul 24, 2023
@takanome-dev
Copy link
Contributor

Make sense 👍 Let's make it a feature request 🍕

@takanome-dev takanome-dev added 💡 feature and removed 🐛 bug Something isn't working 👀 needs triage labels Jul 24, 2023
@babblebey babblebey changed the title Bug: Add Conditional Routing for Single Highlight Dialog Close Button Feature: Add Conditional Routing for Single Highlight Dialog Close Button Jul 25, 2023
@babblebey
Copy link
Contributor Author

I'll just .take it 🍕

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

🎉 This issue has been resolved in version 1.59.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@open-sauced
Copy link
Contributor

open-sauced bot commented Aug 8, 2023

🎉 This issue has been resolved in version 1.59.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@open-sauced open-sauced bot added the released label Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants