-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: improved-extension-navigation #99
Conversation
Tbh, I'm not a fan of using a package that was last updated in Aug 2022 and has <50 stars, over something we can edit easily. But I'll review this tonight. |
I did notice that it hasn't been updated of late. But the implementation of the package is pretty solid and straightforward using You can take a look at the implementation here. They are utility functions exported from a common file. https://github.com/kelsonpw/react-chrome-extension-router/blob/master/src/index.ts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works, and the code looks simpler!
### [1.1.1-beta.1](v1.1.0...v1.1.1-beta.1) (2023-05-22) ### π§βπ» Code Refactoring * improved-extension-navigation ([#99](#99)) ([5b2f5c1](5b2f5c1))
π This PR is included in version 1.1.1-beta.1 π The release is available on GitHub release Your semantic-release bot π¦π |
## [1.2.0](v1.1.0...v1.2.0) (2023-05-25) ### π§βπ» Code Refactoring * improved-extension-navigation ([#99](#99)) ([5b2f5c1](5b2f5c1)) ### π Documentation * dev docs ([#83](#83)) ([4eff6eb](4eff6eb)) ### π Bug Fixes * adds demo to readme ([c27e614](c27e614)) * bump manifest version on main only ([#124](#124)) ([e4a86e4](e4a86e4)) * duplicate-button-injections using guards ([#110](#110)) ([3978766](3978766)) ### π Features * add PR velocity to profile page ([#111](#111)) ([ba7fad6](ba7fad6)) * generate code suggestions via AI ([#90](#90)) ([14eede1](14eede1)), closes [#104](#104) * Manifest.json version bump ([#120](#120)) ([488046b](488046b)) * Resources page to link users to open-sauced feedback/discussions ([#100](#100)) ([3d607ae](3d607ae))
π This PR is included in version 1.2.0 π The release is available on GitHub release Your semantic-release bot π¦π |
### [1.1.1-beta.1](open-sauced/ai@v1.1.0...v1.1.1-beta.1) (2023-05-22) ### π§βπ» Code Refactoring * improved-extension-navigation ([#99](open-sauced/ai#99)) ([5b2f5c1](open-sauced/ai@5b2f5c1))
## [1.2.0](open-sauced/ai@v1.1.0...v1.2.0) (2023-05-25) ### π§βπ» Code Refactoring * improved-extension-navigation ([#99](open-sauced/ai#99)) ([5b2f5c1](open-sauced/ai@5b2f5c1)) ### π Documentation * dev docs ([#83](open-sauced/ai#83)) ([4eff6eb](open-sauced/ai@4eff6eb)) ### π Bug Fixes * adds demo to readme ([c27e614](open-sauced/ai@c27e614)) * bump manifest version on main only ([#124](open-sauced/ai#124)) ([e4a86e4](open-sauced/ai@e4a86e4)) * duplicate-button-injections using guards ([#110](open-sauced/ai#110)) ([3978766](open-sauced/ai@3978766)) ### π Features * add PR velocity to profile page ([#111](open-sauced/ai#111)) ([ba7fad6](open-sauced/ai@ba7fad6)) * generate code suggestions via AI ([#90](open-sauced/ai#90)) ([14eede1](open-sauced/ai@14eede1)), closes [#104](open-sauced/ai#104) * Manifest.json version bump ([#120](open-sauced/ai#120)) ([488046b](open-sauced/ai@488046b)) * Resources page to link users to open-sauced feedback/discussions ([#100](open-sauced/ai#100)) ([3d607ae](open-sauced/ai@3d607ae))
What type of PR is this? (check all applicable)
Description
This PR updates the extension dropdown navigation using the
react-chrome-extension-router
package that results in improved code readability and offers a simplified navigation solution for future pages. Additionally, it eliminates the need for a React context provider and consumer for navigation and prop-passing purposes. This pull request is based on the suggestion from @doaortu.Related Tickets & Documents
Original suggestion
Mobile & Desktop Screenshots/Recordings
No visual changes.
Added tests?
Added to documentation?