Feature: add PR to highlights from the extension

[a0m0rajab]

Type of feature

🍕 Feature

Current behavior

it would be gerat to have an auto add option for PRs/issues to the extension where it will be not let the user move to the highlight page, or at least open highlight page with the PR information loaded (as first step)

Suggested solution

No response

Additional context

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

Contributing Docs

• I agree to follow this project's Contribution Docs

[bdougie]

This is a contribution that will need to be made on open-sauced/insights.

We can leverage ?query params. Pretty straight forward with the next router. Did you want to try it out there?

[a0m0rajab]

I was thinking about something similar to Google Keep extension, where you click on it and it allows you to post it to your account from the extension without the need to open the website.

But your idea is less complex to apply I think, we can use it as a bookmark similar to the YC logic:

javascript:window.location="https://news.ycombinator.com/submitlink?u="+encodeURIComponent(document.location)+"&t="+encodeURIComponent(document.title)

[bdougie]

This is also possible and a better user experience. We have an endpoint in https://api.opensauced.pizza for creating highlights

[a0m0rajab]

I will work on it. Might ship the first draft in a day or two. it will let me get familiar with the extension code as well :)

[bdougie]

Here is a screenshot of the giphy for github experience

[a0m0rajab]

Do you prefer to have it in the comment section or the extension itself, I was thinking about a button: add to highlight.
after pressing the button I was thinking about showing a form with the: title, desc, and link.

[bdougie]

It should be a pencil, similar to AI PR description option. I question if the Highlight is needed and if this could replace that. Especially if the feed will be viewable in the extension #78.

[a0m0rajab]

Sure, i will use the pencil, I was thinking about paper plane but this might be used for the send button.

[a0m0rajab]

This is related to #12 and #64

[a0m0rajab]

The main page,

The post on the highlight page:

I wanted to use the OG data to add the link on the post on highlight page but did not figure how to do that, I might check insights project to get some ideas from there. If I cant figure that out, I will add an input to add a link through it.

[a0m0rajab]

The open graph logic from the insights: https://github.com/open-sauced/insights/blob/beta/components/molecules/GhOpenGraphImg/gh-open-graph-img.tsx

[takanome-dev]

The main page,

The post on the highlight page:

I wanted to use the OG data to add the link on the post on highlight page but did not figure how to do that, I might check insights project to get some ideas from there. If I cant figure that out, I will add an input to add a link through it.

Looking good so far @a0m0rajab👍 At this point, I think you can open a draft pr and add these screenshots to the pr visual changes section 😃

[bdougie]

Highlights need to be associated to a pull request and we now have a way to generate highlight messages.

This addition should include a way to reference the pr for the highlight. Add a highlight option should only show while a pull request is being viewed.

[a0m0rajab]

Thank you for the comment @takanome-dev opened a PR,
@bdougie I did this as a page right now, I can add the logic you mentioned.
I followed the keep design right now, but might change it to giphy if it's needed.

[a0m0rajab]

This is also possible and a better user experience. We have an endpoint in https://api.opensauced.pizza for creating highlights

Example usage for reference: https://github.com/open-sauced/insights/blob/e083ea541c78d0e992d989eda942f3d50bbac980/lib/hooks/createHighlights.ts#L23

[github-actions]

🎉 This issue has been resolved in version 1.3.1-beta.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[github-actions]

🎉 This issue has been resolved in version 1.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀