Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Presenting button when no bio present #24

Closed
bdougie opened this issue Apr 20, 2023 · 1 comment · Fixed by #20
Closed

Bug: Presenting button when no bio present #24

bdougie opened this issue Apr 20, 2023 · 1 comment · Fixed by #20

Comments

@bdougie
Copy link
Member

bdougie commented Apr 20, 2023

Hey @bdougie. Upon investigation, I discovered that GitHub adds a "hidden" attribute to the bio-div of profile pages in case no bio is present, which was the case in https://github.com/dayhaysoos. This attribute affects the visibility of the "View On OpenSauced" button located as a child to the bio-div and causes it to remain hidden from view. I'll try to to update how the "View On OpenSauced" button gets added onto the page.
hidden-bio

Originally posted by @Anush008 in #20 (comment)
@bdougie bdougie mentioned this issue Apr 20, 2023
Merged
19 tasks
@Anush008
Copy link
Member

Anush008 commented Apr 20, 2023 •
edited
Loading

The updated selector resolves this.
Here e792985.

@Anush008 Anush008 linked a pull request Apr 20, 2023 that will close this issue
feat: Invite to OpenSauced #20
Merged
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Invite to OpenSauced open-sauced/ai
2 participants
@bdougie @Anush008