feat: Login with pkce #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diivi
approved these changes
Jul 28, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Jul 28, 2023
## [1.12.0-beta.5](v1.12.0-beta.4...v1.12.0-beta.5) (2023-07-28) ### 🍕 Features * Login with pkce ([#230](#230)) ([42e8d4a](42e8d4a))
|
🎉 This PR is included in version 1.12.0-beta.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This was referenced Jul 28, 2023
Merged
bdougie
added a commit
that referenced
this pull request
Jul 31, 2023
* feat: view repos on opensauced (#218) * feat: view repos on opensauced * change var names * chore(minor): release 1.12.0-beta.1 on beta channel [skip ci] ## [1.12.0-beta.1](v1.11.1...v1.12.0-beta.1) (2023-07-18) ### 🍕 Features * view repos on opensauced ([#218](#218)) ([f33d9fd](f33d9fd)) * fix: post highlights from the extension (#223) * chore(patch): release 1.12.0-beta.2 on beta channel [skip ci] ## [1.12.0-beta.2](v1.12.0-beta.1...v1.12.0-beta.2) (2023-07-19) ### 🐛 Bug Fixes * post highlights from the extension ([#223](#223)) ([7d91011](7d91011)) * fix: redirect to home page after posting a highlight (#203) * fix: redirect to home page after posting a highligh * Added forceRefresh param to force cache invalidation * chore: default val forceRefresh, typo --------- Co-authored-by: Anush008 <[email protected]> * chore(patch): release 1.12.0-beta.3 on beta channel [skip ci] ## [1.12.0-beta.3](v1.12.0-beta.2...v1.12.0-beta.3) (2023-07-20) ### 🐛 Bug Fixes * redirect to home page after posting a highlight ([#203](#203)) ([4ebd2d1](4ebd2d1)) * fix: view on open sauced location (#225) * bug-fix: view on open sauced location * fix: change classname to constant name * fix: remove unwanted lint changes in constants * feat: change variable name * fix: remove element cast Co-authored-by: Nick Taylor <[email protected]> --------- Co-authored-by: Nick Taylor <[email protected]> * chore(patch): release 1.12.0-beta.4 on beta channel [skip ci] ## [1.12.0-beta.4](v1.12.0-beta.3...v1.12.0-beta.4) (2023-07-25) ### 🐛 Bug Fixes * view on open sauced location ([#225](#225)) ([0ecfef0](0ecfef0)) * feat: Login with pkce (#230) * chore(minor): release 1.12.0-beta.5 on beta channel [skip ci] ## [1.12.0-beta.5](v1.12.0-beta.4...v1.12.0-beta.5) (2023-07-28) ### 🍕 Features * Login with pkce ([#230](#230)) ([42e8d4a](42e8d4a)) --------- Co-authored-by: Divyansh Singh <[email protected]> Co-authored-by: Marcus Chan <[email protected]> Co-authored-by: Anush008 <[email protected]> Co-authored-by: Pratham <[email protected]> Co-authored-by: Nick Taylor <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Jul 31, 2023
## [1.12.0](v1.11.1...v1.12.0) (2023-07-31) ### 🍕 Features * Login with pkce ([#230](#230)) ([42e8d4a](42e8d4a)) * view repos on opensauced ([#218](#218)) ([f33d9fd](f33d9fd)) ### 🐛 Bug Fixes * manual release.yml ([a41de3f](a41de3f)) * post highlights from the extension ([#223](#223)) ([7d91011](7d91011)) * redirect to home page after posting a highlight ([#203](#203)) ([4ebd2d1](4ebd2d1)) * view on open sauced location ([#225](#225)) ([0ecfef0](0ecfef0))
|
🎉 This PR is included in version 1.12.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As explained in #228 (comment), currently users have to click the "Connect with GitHub" button on
insights.opensauced.pizzato log into the extension due to the introduction of PKCE to the Supabase auth flow.A redirection to the login URL won't work anymore as every login request will need to have a
code_challengeand theverifiercode stored as the cookie.This PR intends to resolve this by implementing the same.
What type of PR is this? (check all applicable)
Related Tickets & Documents
Resolves #228.
Mobile & Desktop Screenshots/Recordings
CURRENT BEHAVIOUR
PROPOSED CHANGE
Added tests?
Added to documentation?