Bug: cannot login with the extension

[takanome-dev]

Describe the bug

extension-auth-bug.mp4

Steps to reproduce

1. Logout from the Insights or Hot platform
2. Use the extension to login back in

Browsers

Other (add additional context)

Additional context (Is this in dev or production?)

Browser: Brave

Code of Conduct

• I agree to follow this project's Code of Conduct

Contributing Docs

• I agree to follow this project's Contribution Docs

[Anush008]

From the video, I believe you are not logged into beta.insights.opensauced.pizza. You'll have to click the "Connect with GitHub` button on the top right.

[takanome-dev]

Yeah, that's right. But I remember that clicking the login button in the extension automatically logs you and redirects you to insights.opensauced.pizza (if I'm not mistaken 🤔)

[diivi]

It used to, yes. But since the last month I've had to click the Connect to Github button separately.

[takanome-dev]

Is it the credentials(env) or because it redirects to beta.insights?

[diivi]

How are you using the extension? If it's in dev, npm run dev, it should redirect to beta.insights only.

[Anush008]

I tried digging into this.

The reason we'll have to click the "Connect with GitHub" button to log into the extension from now on is because the @supabase/auth-helpers lib used at insights.opensauced.pizza was updated last month.
open-sauced/app#1301 which introduced PKCE to the auth flow.

• https://supabase.com/blog/supabase-auth-sso-pkce#introducing-pkce
• feat: add pkce supabase/auth-js#591

Prior to this we would redirect users to

ai/src/constants.ts

Line 4 in e95e7a1

export const SUPABASE_LOGIN_URL = `https://${import.meta.env.VITE_OPEN_SAUCED_SUPABASE_ID}.supabase.co/auth/v1/authorize?provider=github&redirect_to=https://${OPEN_SAUCED_INSIGHTS_DOMAIN}/`;

Which would log the users in with the following params

Now with PKCE in place, a code-challenge, verifier value has to be generated and stored at insights.opensauced.pizza while making the login request. That's what happens when we click on the "Connect to GitHub" button. Handled by the @supabase/auth-helpers lib implictly.

As of now, there's no way to disable PKCE at insights.opensauced.pizza because the @supase/auth-helpers lib has it hardcoded as the auth flow type.
https://github.com/supabase/auth-helpers/blob/9715901658e0925136b9c8c015b6d5c22a7ce6a7/packages/shared/src/createClient.ts#L30

[github-actions]

🎉 This issue has been resolved in version 1.12.0-beta.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[github-actions]

🎉 This issue has been resolved in version 1.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀