Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: chat dialog for talking to repos #226

Merged
merged 17 commits into from
Aug 10, 2023
Merged

feat: chat dialog for talking to repos #226

merged 17 commits into from
Aug 10, 2023

Conversation

diivi
Copy link
Contributor

@diivi diivi commented Jul 20, 2023 •
edited
Loading

Description

Draft PR to share updates related to #192

  • Inject Chat button
  • Work on chat dialog and bubbles
  • User prompts
  • Feedback on load/SSE.

Flow:

Chat Dialog Opens -> User clicks on start chatting (similar to sitegpt) -> check if repo is indexed

yes -> open messaging UI with user suggestions and prompts like:

no -> ask user if they would like to index the repo for talking to it afterwards -> wait for indexing -> messaging UI

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

#192

Mobile & Desktop Screenshots/Recordings

demo

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md
  • 📓 docs.opensauced.pizza
  • 🍕 dev.to/opensauced
  • 📕 storybook
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@Anush008 Anush008 mentioned this pull request Jul 22, 2023
Merged
This was referenced Jul 27, 2023
Closed
Closed
@diivi
Copy link
Contributor Author

diivi commented Jul 30, 2023

demo

@diivi
Copy link
Contributor Author

diivi commented Jul 30, 2023 •
edited by Anush008
Loading

Work left to do:

  • Get the default branch name for the repository and use that (currently using "beta" hardcoded)
  • Suggested Prompts for the user (any ideas?)

After this we can probably merge the PR and work on additional features once this is out.

@bdougie
Copy link
Member

bdougie commented Jul 30, 2023 •
edited
Loading

Get the default branch name for the repository and use that (currently using "beta" hardcoded)

HEAD is redirects to the default. So instead of beta you can use HEAD, all caps.

Suggested Prompts for the user (any ideas?)

  1. Return functions that fail the single responsibility principle.

  2. Returns functions with side affects.

@jpmcb jpmcb marked this pull request as ready for review July 31, 2023 16:38
@jpmcb
Copy link
Member

jpmcb commented Jul 31, 2023

Whoops - accidentally clicked ready for review on GitHub mobile 😵

@diivi
Copy link
Contributor Author

diivi commented Jul 31, 2023 •
edited
Loading

was gonna do it anyway :P

Let's do some reviews and go live with this!

@diivi diivi force-pushed the feat/talk-to-repositories branch from e2720bd to d264add Compare July 31, 2023 17:22
Anush008
Anush008 approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@Anush008 Anush008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀

@bdougie
Copy link
Member

bdougie commented Jul 31, 2023 •
edited
Loading

We may want to deploy the repo-query to an opensauced managed instance.

nickytonline
nickytonline requested changes Aug 1, 2023
View reviewed changes
Copy link
Member

@nickytonline nickytonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments and change requests. This is looking great @diivi!

src/content-scripts/components/RepoQuery/RepoQuery.tsx Outdated Show resolved Hide resolved
src/repo-query/components/ChatCircle.tsx Outdated Show resolved Hide resolved
src/repo-query/components/Dialog.tsx Show resolved Hide resolved
src/repo-query/pages/chat.tsx Outdated Show resolved Hide resolved
src/repo-query/pages/chat.tsx Outdated Show resolved Hide resolved
@nickytonline
Copy link
Member

nickytonline commented Aug 1, 2023 •
edited
Loading

One thing I noticed is when you open the chat the X for the close icon is not centered. Changing display from block to flex sorts it out so that justify-content and align-items take effect. Not marking it as blocking for the PR, but it'd be good to sort that out.

CleanShot 2023-08-01 at 08 54 26

nickytonline
nickytonline approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@nickytonline nickytonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes @diivi. Took it for a spin. Nice work! 🚢

@diivi
Copy link
Contributor Author

diivi commented Aug 1, 2023 •
edited
Loading

Not marking it as blocking for the PR, but it'd be good to sort that out.

This was reported here - open-sauced/app#1407

Not a problem with the feature in this PR, right?

@nickytonline
Copy link
Member

Not marking it as blocking for the PR, but it'd be good to sort that out.

This was reported here - open-sauced/insights#1407

Not a problem with the feature in this PR, right?

Yeah, not blocking at all. I thought it was code in this PR, but it isn't.

@bdougie bdougie mentioned this pull request Aug 1, 2023
Open
2 tasks
@diivi
Copy link
Contributor Author

diivi commented Aug 3, 2023

@bdougie can we merge this now?

@bdougie
Copy link
Member

bdougie commented Aug 3, 2023

Waiting on the DNS swap. @jpmcb is working on that.

@bdougie bdougie merged commit 67f04d7 into beta Aug 10, 2023
github-actions bot pushed a commit that referenced this pull request Aug 10, 2023
@diivi @open-sauced
chore(minor): release 1.13.0-beta.1 on beta channel [skip ci]
69274ed 
## [1.13.0-beta.1](v1.12.1...v1.13.0-beta.1) (2023-08-10)

### 🍕 Features

* chat dialog for talking to repos ([#226](#226)) ([67f04d7](67f04d7))
@github-actions
Copy link

🎉 This PR is included in version 1.13.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request Aug 10, 2023
@bdougie @open-sauced
chore(minor): release 1.13.0 [skip ci]
5ea6f13 
## [1.13.0](v1.12.1...v1.13.0) (2023-08-10)

### 🍕 Features

* chat dialog for talking to repos ([#226](#226)) ([67f04d7](67f04d7))
@github-actions
Copy link

🎉 This PR is included in version 1.13.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdougie bdougie bdougie left review comments

@Anush008 Anush008 Anush008 approved these changes

@nickytonline nickytonline nickytonline approved these changes

Assignees
No one assigned
Labels
released on @beta released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@diivi @bdougie @jpmcb @nickytonline @Anush008