-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Broken authentication on dev #215
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works!
Curious if this is the same issue happening hot.opensauced.pizza - open-sauced/hot#477 At lease the cookie name checks. |
The While the one for hot.opensauced.pizza, https://ibcwmlhcimymasokhgvn.supabase.co/, is working fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this
## [1.11.1-beta.2](v1.11.1-beta.1...v1.11.1-beta.2) (2023-07-15) ### 🐛 Bug Fixes * Broken authentication on dev ([#215](#215)) ([c6bf2c8](c6bf2c8))
🎉 This PR is included in version 1.11.1-beta.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 1.11.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
## [1.11.1-beta.2](open-sauced/ai@v1.11.1-beta.1...v1.11.1-beta.2) (2023-07-15) ### 🐛 Bug Fixes * Broken authentication on dev ([#215](open-sauced/ai#215)) ([c6bf2c8](open-sauced/ai@c6bf2c8))
## [1.11.1](open-sauced/ai@v1.11.0...v1.11.1) (2023-07-18) ### ✅ Tests * api responses match our expectations ([#216](open-sauced/ai#216)) ([7f79b0a](open-sauced/ai@7f79b0a)) ### 🐛 Bug Fixes * Broken authentication on dev ([#215](open-sauced/ai#215)) ([c6bf2c8](open-sauced/ai@c6bf2c8))
Description
This PR intends to fix the broken dev auth due to a changed cookie key.
The auth cookie name at https://beta.insights.opensauced.pizza is
sb-fcqqkxwlntnrtjfbcioz-auth-token
. At https://insights.opensauced.pizza it issupabase-auth-token
.The
useAuth
hook has been improved to check and propagate auth. ThecheckAuthentication
function has been removed along with theonInstalled
,onStartup
andcookies.onChanged
background listeners as theuseAuth
hook will suffice from here on.Any future changes to the key will have to be updated here.
ai/src/constants.ts
Line 7 in cc76e95
The rest of the authentication can remain unchanged.
What type of PR is this? (check all applicable)
Related Tickets & Documents
Resolves #214.
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?