-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Change highlight author to github handles #160
Comments
This is needed before we can release. #155 The links to the insight platform are linked to profiles that exist. |
@a0m0rajab or @Anush008 I am trying to change this line: to: highlights[currentPage]?.login but the error states the {
"id": 237133,
"user_id": 237133,
"url": "github.com/open-sauced/insights/pull/1",
"title": "My First PR!",
"highlight": "\n I made my first open source pull request!\n \n github.com/open-sauced/insights/pull/1",
"pinned": false,
"created_at": "2023-01-19 13:24:51.000000",
"updated_at": "2023-01-19 13:24:51.000000",
"deleted_at": "2023-01-19 13:24:51.000000",
"shipped_at": "2023-01-19 13:24:51.000000",
"full_name": "open-sauced/insights",
"name": "Brian Douglas",
"login": "bdougie"
} |
nvm, it is clearly defined here https://github.com/open-sauced/ai/blob/beta/src/pages/home.tsx#L21-L26 |
🎉 This issue has been resolved in version 1.4.0-beta.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This issue has been resolved in version 1.4.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Type of feature
🍕 Feature
Current behavior
The author is displayed as a full name, but it should be the GitHub handle.
Suggested solution
The
formatNameForLink
is not needed on this line and instead of.name
it should be.login
https://github.com/open-sauced/ai/pull/154/files#diff-7c8d28ff1de800f1a1770a7f9bf600faa23af4ef36b2b27e7af3cc0b4b473ff4R122
Additional context
Use
login
instead ofname
Code of Conduct
Contributing Docs
The text was updated successfully, but these errors were encountered: