Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: post to highlight in dev mode is redirecting to prod website #153

Closed
1 of 2 tasks
a0m0rajab opened this issue May 30, 2023 · 4 comments · Fixed by #163
Closed
1 of 2 tasks

Bug: post to highlight in dev mode is redirecting to prod website #153

a0m0rajab opened this issue May 30, 2023 · 4 comments · Fixed by #163
Labels
🐛 bug Something isn't working good first issue Good for newcomers released on @beta released

Comments

@a0m0rajab
Copy link
Contributor

a0m0rajab commented May 30, 2023

Describe the bug

When you post something from the dev mode, the whole workflow works right, but the feedback to the user is redirecting to the wrong place.

Steps to reproduce

  1. open the pop up in dev mode
  2. click on post to highlight
  3. post the PR or issue to highlights
  4. click on the view on insights page.
  5. you will be redirected to the prod

Solution

  1. 🔍 find the related button
  2. 👏 update the link
🔥 Hint:

Here is the related link:

href={`https://insights.opensauced.pizza/user/${user?.user_name}/highlights`}

🤔 How to use it?

You can see how we used the constants file to use it here as well.

Affected services

browser-extension

Platforms

No response

Browsers

No response

Environment

No response

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

Contributing Docs

  • I agree to follow this project's Contribution Docs
@a0m0rajab a0m0rajab added good first issue Good for newcomers 🐛 bug Something isn't working labels May 30, 2023
@bdougie
Copy link
Member

bdougie commented May 30, 2023

This is a known issue. We have a dev auth that I don't believe we are using.

There is a second supabase auth in open-sauced/insights to handle this.

@a0m0rajab
Copy link
Contributor Author

This is happening to hard-coding the domain, in the popup if we added the domain from .env it will solve the issue.

@github-actions
Copy link

github-actions bot commented Jun 4, 2023

🎉 This issue has been resolved in version 1.4.1-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Jun 6, 2023

🎉 This issue has been resolved in version 1.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working good first issue Good for newcomers released on @beta released
Projects
Development

Successfully merging a pull request may close this issue.

2 participants