Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: view on open sauced location #146

Closed
1 of 2 tasks
a0m0rajab opened this issue May 27, 2023 · 12 comments · Fixed by #225 or #278
Closed
1 of 2 tasks

Bug: view on open sauced location #146

a0m0rajab opened this issue May 27, 2023 · 12 comments · Fixed by #225 or #278
Assignees
Labels
🐛 bug Something isn't working good first issue Good for newcomers released on @beta released

Comments

@a0m0rajab
Copy link
Contributor

Describe the bug

When you open a profile that does not have a bio, the view on open source will not show.

Steps to reproduce

  1. go to your profile
  2. remove your bio
  3. refresh the page :)

Affected services

browser-extension

Platforms

No response

Browsers

No response

Environment

No response

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

Contributing Docs

  • I agree to follow this project's Contribution Docs
@a0m0rajab a0m0rajab added the 🐛 bug Something isn't working label May 27, 2023
@a0m0rajab
Copy link
Contributor Author

a0m0rajab commented May 27, 2023

This is related to: #97 and #97

Suggested solution:

  1. 🔍 find a unique identifier for the profile menu by doing the next:
  2. 🕵️ Inspect the profile page, the bio, and the edit button.
  3. 👍 see if we can find a unique identifier to use it.
  4. 🏥 review the code and the JS query selector to use that identifier

Challenge

Let this work on your profile and other people's profiles.
For your profile, it will be under the bio information on top of the edit profile,
For other people's profiles

😄 Hint

You might find a unique selector for the edit profile button, the hints are a way to show you direction you might need to inspect further.

Your own profile selector: show the selector

btn-block js-profile-editable-edit-button

Other people profile selector:

user-following-container

Use a condition maybe You can check if the selector is not provided for your profile to trigger the selector for other people profiles, and add the button, in cases it will be need to be prepended.
🎨 Style hint You will need to change the style and find the right way to add related margins.

Expected results:

Issues title The problem right now The expected look
Others profiles image image
Personal profiles image image
Personal Profiles without bio image The button should be visible
Profiles with sponsorship image image

Note: this should not break showing the icon on profiles without a bio.

@a0m0rajab a0m0rajab added the good first issue Good for newcomers label May 27, 2023
@a0m0rajab a0m0rajab changed the title Bug: view on open sauced is not showing if you do not have bio. Bug: view on open sauced location May 27, 2023
@amartya3ac
Copy link

I CAN DO IT. ASSIGN ME.

@a0m0rajab
Copy link
Contributor Author

@amartya3ac, the issue is assigned to you. Feel free to take issues to check the contributor guide as well:

https://docs.opensauced.pizza/contributing/introduction-to-contributing/#issues

@bdougie bdougie moved this to In Progress in Extension Status Board Jun 3, 2023
@bdougie bdougie added this to the Extension Features milestone Jun 27, 2023
@diivi
Copy link
Contributor

diivi commented Jul 11, 2023

Hey @amartya3ac are you still working on this?

@Pratham-19
Copy link
Contributor

Hi @diivi can I work on this ?

@diivi
Copy link
Contributor

diivi commented Jul 20, 2023

Sure, go ahead!

@Pratham-19
Copy link
Contributor

@diivi @a0m0rajab Please check now I have added a pr

@github-project-automation github-project-automation bot moved this from In Progress to Done in Extension Status Board Jul 25, 2023
@github-actions
Copy link

🎉 This issue has been resolved in version 1.12.0-beta.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@a0m0rajab
Copy link
Contributor Author

Reponing due to not being fixed: #225 (comment)

@a0m0rajab a0m0rajab reopened this Jul 25, 2023
@github-actions
Copy link

🎉 This issue has been resolved in version 1.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Copy link

github-actions bot commented Nov 5, 2023

🎉 This issue has been resolved in version 1.14.2-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Copy link

github-actions bot commented Nov 6, 2023

🎉 This issue has been resolved in version 1.14.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment