-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Logout from the extension #138
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving but want to point out we should start testing everything in the utils folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't tested this out, but code looks good.
## [1.3.0-beta.2](v1.3.0-beta.1...v1.3.0-beta.2) (2023-05-26) ### π Features * Logout from the extension ([#138](#138)) ([1f62f0e](1f62f0e))
π This PR is included in version 1.3.0-beta.2 π The release is available on GitHub release Your semantic-release bot π¦π |
## [1.3.0](v1.2.0...v1.3.0) (2023-05-27) ### π Features * adds test and lint to build ([#127](#127)) ([6f1cfc7](6f1cfc7)) * Logout from the extension ([#138](#138)) ([1f62f0e](1f62f0e)) ### β Tests * setup tests ([#139](#139)) ([8d61ab0](8d61ab0)) ### π Bug Fixes * run builds on PRs ([a755e38](a755e38))
π This PR is included in version 1.3.0 π The release is available on GitHub release Your semantic-release bot π¦π |
## [1.3.0-beta.2](open-sauced/ai@v1.3.0-beta.1...v1.3.0-beta.2) (2023-05-26) ### π Features * Logout from the extension ([#138](open-sauced/ai#138)) ([1f62f0e](open-sauced/ai@1f62f0e))
## [1.3.0](open-sauced/ai@v1.2.0...v1.3.0) (2023-05-27) ### π Features * adds test and lint to build ([#127](open-sauced/ai#127)) ([6f1cfc7](open-sauced/ai@6f1cfc7)) * Logout from the extension ([#138](open-sauced/ai#138)) ([1f62f0e](open-sauced/ai@1f62f0e)) ### β Tests * setup tests ([#139](open-sauced/ai#139)) ([8d61ab0](open-sauced/ai@8d61ab0)) ### π Bug Fixes * run builds on PRs ([a755e38](open-sauced/ai@a755e38))
What type of PR is this? (check all applicable)
Description
This PR includes three changes:
Generated using OpenSauced.
The utility functions added to support logout/login have been prefixed with
opt
to distinguish as auth-utility functions called on explicit user actions and not on events likeonInstalled
oronStartUp
.ai/src/utils/checkAuthentication.ts
Lines 45 to 58 in f08e217
The max description length has been set to 500 in accordance to the API constraints.
https://github.com/open-sauced/api.opensauced.pizza/blob/e55f963aa4f3fda34440fc035d45776d244408eb/src/pull-requests/dtos/create-pull-request-description.dto.ts#L5-L13
Related Tickets & Documents
Resolves #116, #102.
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?