Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Limit permissions for the extension to GitHub #102

Closed
1 of 2 tasks
bdougie opened this issue May 23, 2023 · 3 comments · Fixed by #138
Closed
1 of 2 tasks

Feature: Limit permissions for the extension to GitHub #102

bdougie opened this issue May 23, 2023 · 3 comments · Fixed by #138

Comments

@bdougie
Copy link
Member

bdougie commented May 23, 2023

Type of feature

🍕 Feature

Current behavior

Screen Shot 2023-05-22 at 5 18 32 PM

Suggested solution

By default these settings is marked for "all sites"

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

Contributing Docs

  • I agree to follow this project's Contribution Docs
@diivi diivi added the good first issue Good for newcomers label May 23, 2023
@bdougie
Copy link
Member Author

bdougie commented May 23, 2023

@diivi this is not quite a good first issue until it provides the solution. https://opensauced.pizza/blog/good-first-issues-dont-exist

@diivi
Copy link
Contributor

diivi commented May 23, 2023

@Anush008 can the authentication really function without having access to websites other than GitHub? I tried changing the host_permissions, and couldn't log in anymore.

If so,

"host_permissions": ["https://github.com/*,"the_url_we_use_for_auth"]

@diivi diivi removed the good first issue Good for newcomers label May 23, 2023
@Anush008
Copy link
Member

Anush008 commented May 23, 2023

@diivi, we'll be needing "https://insights.opensauced.pizza/*" in the host_permissions array for the auth to work.

export const OPEN_SAUCED_INSIGHTS_DOMAIN = "insights.opensauced.pizza";

chrome.cookies.get(
{
name: SUPABASE_AUTH_COOKIE_NAME,
url: `https://${OPEN_SAUCED_INSIGHTS_DOMAIN}`,
},

The getter above won't return a value without access to https://insights.opensauced.pizza/* .

@Anush008 Anush008 linked a pull request May 26, 2023 that will close this issue
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

3 participants