Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Resources page to link users to open-sauced feedback/discussions #100

Merged
merged 14 commits into from
May 23, 2023

Conversation

Nanak360
Copy link
Contributor

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Description

Add a new page "Resources" to the app with external links to Discussions and Issues.
The page can be accessed from the Home page. It contains a list of external links to Discussions and Issues. The Discussions and Issues links are displayed with an arrow icon and descriptive text. The Resources page also contains a back button to return to the Home page.

Generated using OpenSauced.

Related Tickets & Documents

Fixes #96

Mobile & Desktop Screenshots/Recordings

open-sauced.Discussions.GitHub.mp4

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@Anush008 Anush008 changed the title Feature/add resources page to link the users to open-sauced/feedback/discussions feat: Resources page to link users to open-sauced feedback/discussions May 22, 2023
src/constants.ts Outdated Show resolved Hide resolved
src/pages/home.tsx Outdated Show resolved Hide resolved
src/App.tsx Outdated Show resolved Hide resolved
@Nanak360
Copy link
Contributor Author

Current status after the modifications

Initial state

image

On hover

image

Resources page

image

@Nanak360 Nanak360 marked this pull request as ready for review May 22, 2023 17:36
Copy link
Member

@bdougie bdougie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The user experience is not great with this. The buttons all look the same and we have not distinguished between features and links.

Can we do the following?

  1. Move external links to the bottom of the list as shorted items separated by a
    .
  2. Rename "Resources" to "External Links"

Here is an example of the original design that we can follow.
227880325-d10fe310-1489-4f23-bbc1-3762dc11d7fa

@Nanak360
Copy link
Contributor Author

The user experience is not great with this. The buttons all look the same and we have not distinguished between features and links.

Can we do the following?

  1. Move external links to the bottom of the list as shorted items separated by a .
  2. Rename "Resources" to "External Links"

Here is an example of the original design that we can follow. 227880325-d10fe310-1489-4f23-bbc1-3762dc11d7fa

Regarding your question, if we move the external links to the bottom of the home page, it means that we no longer need a separate "Resources" or "External Links" page, as the links will be directly accessible from the home page.

I believe this is what we are aiming for

image

@bdougie
Copy link
Member

bdougie commented May 23, 2023

@Nanak360 do you have a new clean shot or demo with the new style buttons?

@Nanak360
Copy link
Contributor Author

Nanak360 commented May 23, 2023

Hey @bdougie
Here is the demo with the proper buttons

Insights.Hub._.Open.Sauced.Insights.mp4

I also have the following interpretation of this feature.

feat_.Resources.page.to.link.users.to.open-sauced.feedback_discussions.by.Nanak360.Pull.Request.100.open-sauced_ai.online-video-cutter.com.mp4

Will push whichever seems better to the community.

@bdougie
Copy link
Member

bdougie commented May 23, 2023

I prefer the second but can we rename this to "Help" and add a link to docs.opensauced.pizza, specifically the link to the extension docs.

@Nanak360
Copy link
Contributor Author

Renamed externals as Help and replaced a new icon

Screenshot from 2023-05-23 21-41-48

Added the docs link as well.

image

@diivi
Copy link
Contributor

diivi commented May 23, 2023

Maybe the icons for docs issues and discussions can also be taken from github (Too many external link icons), looks good otherwise.

Copy link
Member

@bdougie bdougie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this

Copy link
Contributor

@diivi diivi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks! @Nanak360

@Nanak360
Copy link
Contributor Author

Maybe the icons for docs issues and discussions can also be taken from github (Too many external link icons), looks good otherwise.

yeah I think this looks better
image

should I push these changes?

@diivi
Copy link
Contributor

diivi commented May 23, 2023

Yup, looks great.

@diivi diivi merged commit 3d607ae into open-sauced:beta May 23, 2023
github-actions bot pushed a commit that referenced this pull request May 23, 2023
## [1.2.0-beta.1](v1.1.1-beta.2...v1.2.0-beta.1) (2023-05-23)

### πŸ• Features

* Resources page to link users to open-sauced feedback/discussions ([#100](#100)) ([3d607ae](3d607ae))
@github-actions
Copy link

πŸŽ‰ This PR is included in version 1.2.0-beta.1 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

github-actions bot pushed a commit that referenced this pull request May 25, 2023
## [1.2.0](v1.1.0...v1.2.0) (2023-05-25)

### πŸ§‘β€πŸ’» Code Refactoring

* improved-extension-navigation ([#99](#99)) ([5b2f5c1](5b2f5c1))

### πŸ“ Documentation

* dev docs ([#83](#83)) ([4eff6eb](4eff6eb))

### πŸ› Bug Fixes

* adds demo to readme ([c27e614](c27e614))
* bump manifest version on main only ([#124](#124)) ([e4a86e4](e4a86e4))
* duplicate-button-injections using guards ([#110](#110)) ([3978766](3978766))

### πŸ• Features

* add PR velocity to profile page ([#111](#111)) ([ba7fad6](ba7fad6))
* generate code suggestions via AI ([#90](#90)) ([14eede1](14eede1)), closes [#104](#104)
* Manifest.json version bump ([#120](#120)) ([488046b](488046b))
* Resources page to link users to open-sauced feedback/discussions ([#100](#100)) ([3d607ae](3d607ae))
@github-actions
Copy link

πŸŽ‰ This PR is included in version 1.2.0 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

zer0and1 pushed a commit to zer0and1/open-sauced.ai that referenced this pull request Jul 26, 2023
## [1.2.0-beta.1](open-sauced/ai@v1.1.1-beta.2...v1.2.0-beta.1) (2023-05-23)

### πŸ• Features

* Resources page to link users to open-sauced feedback/discussions ([#100](open-sauced/ai#100)) ([3d607ae](open-sauced/ai@3d607ae))
zer0and1 pushed a commit to zer0and1/open-sauced.ai that referenced this pull request Jul 26, 2023
## [1.2.0](open-sauced/ai@v1.1.0...v1.2.0) (2023-05-25)

### πŸ§‘β€πŸ’» Code Refactoring

* improved-extension-navigation ([#99](open-sauced/ai#99)) ([5b2f5c1](open-sauced/ai@5b2f5c1))

### πŸ“ Documentation

* dev docs ([#83](open-sauced/ai#83)) ([4eff6eb](open-sauced/ai@4eff6eb))

### πŸ› Bug Fixes

* adds demo to readme ([c27e614](open-sauced/ai@c27e614))
* bump manifest version on main only ([#124](open-sauced/ai#124)) ([e4a86e4](open-sauced/ai@e4a86e4))
* duplicate-button-injections using guards ([#110](open-sauced/ai#110)) ([3978766](open-sauced/ai@3978766))

### πŸ• Features

* add PR velocity to profile page ([#111](open-sauced/ai#111)) ([ba7fad6](open-sauced/ai@ba7fad6))
* generate code suggestions via AI ([#90](open-sauced/ai#90)) ([14eede1](open-sauced/ai@14eede1)), closes [#104](open-sauced/ai#104)
* Manifest.json version bump ([#120](open-sauced/ai#120)) ([488046b](open-sauced/ai@488046b))
* Resources page to link users to open-sauced feedback/discussions ([#100](open-sauced/ai#100)) ([3d607ae](open-sauced/ai@3d607ae))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Link the users to open-sauced/feedback/discussions for feedback
3 participants