build: bump github.com/golang/glob, remove replace directive #7056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just recently, glog introduced a fix for the potentially very expensive network call on windows that had been troubling us before: golang/glog@9730314 It's become the v1.2.2 release. The release is now in vendor, and the replacement has been removed. Fixes open-policy-agent#7024. Signed-off-by: Stephan Renatus <[email protected]>
srenatus
commented
Sep 24, 2024
Comment on lines
+9
to
+11
| // This follows the logic in the standard library's user.Current() function, except | ||
| // that it leaves out the potentially expensive calls required to look up the user's | ||
| // display name in Active Directory. |
There was a problem hiding this comment.
☝️ That's the important bit.
✅ Deploy Preview for openpolicyagent ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
anderseknert
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Awesome!
glog is only used through badger
Is this still the case? I don't see it here: https://github.com/dgraph-io/badger/blob/main/go.mod
But looks like we're severly lagging behind on that dependency, so...
|
|
@srenatus yes, I'm saying they don't seem to use it any more, not that it's not used by the version we depend on. |
|
I'm saying that they never did -- it's been an indirect dependency, and it still is :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just recently, glog introduced a fix for the potentially very expensive network call on windows that had been troubling us before:
golang/glog@9730314
It's become the v1.2.2 release.
The release is now in vendor, and the replacement has been removed.
Fixes #7024.