Add dependency-management-data logo #6543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for openpolicyagent ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hi Jamie, this looks good to me. the preview is a little funny at https://deploy-preview-6543--openpolicyagent.netlify.app/integrations/dependency-management-data/, but we need to address that with CSS rather than in the PR. Can you rebase and sign off the commit for the DCO check? then we can get this in. |
|
p.s. the new logo is ✨ ! I like it! |
Now we've got one, we should use it! Signed-off-by: Jamie Tanna <[email protected]>
|
Thanks very much, very happy with it and the designer who did it 😄 Ah yes, that looks interesting 😅 |
charlieegan3
approved these changes
Jan 24, 2024
charlieegan3
added a commit
to charlieegan3/opa
that referenced
this pull request
Jan 24, 2024
Issue identified in open-policy-agent#6543 Signed-off-by: Charlie Egan <[email protected]>
|
Thanks for the prompt rebase, I should have a fix in #6544 |
charlieegan3
added a commit
that referenced
this pull request
Jan 24, 2024
Issue identified in #6543 Signed-off-by: Charlie Egan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why the changes in this PR are needed?
Now we've got a logo for the project, we should use it!
What are the changes in this PR?
Notes to assist PR review:
Further comments: