silencing the SDK to ensure it does not panic #4314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srenatus
reviewed
Feb 1, 2022
sdk/options.go
Outdated
| bs, err := ioutil.ReadAll(o.Config) | ||
| if err != nil { | ||
| return err | ||
| var bs = []byte("{}") |
There was a problem hiding this comment.
[nit] This should be the same as
Suggested change
| var bs = []byte("{}") | |
| bs := []byte("{}") |
where I think the bs := variant is a bit more consistent with the overall code style
There was a problem hiding this comment.
Made the recommended adjustments and added a test case.
johanfylling
reviewed
Feb 1, 2022
sdk/options.go
Outdated
| var bs = []byte("{}") | ||
|
|
||
| if o.Config == nil { | ||
| o.config = bs |
There was a problem hiding this comment.
Also a nit: I think we could inline the value of bs here, as there is really no need for it in the outer scope: o.config = []byte("{}")
There was a problem hiding this comment.
I actually like this one better. Making that adjustment now
srenatus
previously approved these changes
Feb 2, 2022
|
If you wouldn't mind, could you please also squash the commits? A short message including would be great, too. |
Signed-off-by: Damien Burks <[email protected]>
damienjburks
force-pushed
the
issue-4303
branch
from
f99e916
to
a01c864
Compare
|
@srenatus Everything looks good to me. Please check and confirm when you get a chance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #4303