Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added timestamp #3695

Closed
wants to merge 1 commit into from
Closed

Conversation

sujanks
Copy link

@sujanks sujanks commented Aug 3, 2021

No description provided.

@srenatus
Copy link
Contributor

srenatus commented Aug 3, 2021

Hey @sujanks, thanks for contributing!

Just looking at the commit, I could use some context... you seem to be adding a way to have the JSON logs carry timestamps in a certain format...? Could you please go into some detail on what you want to achieve? We could then discuss the best way to implement it. I'd be happy to give you some pointers on how to make such a thing configurable by the ordinary means (OPA's config, not some env variable).

👉 Most of what would be great to add is outlined in CONTRIBUTING.md, too.

@tsandall
Copy link
Member

tsandall commented Aug 9, 2021

This has come up in the past; I think the original issue that I filed was in response to someone wanting to limit the timestamp precision: #2413.

I agree with @srenatus that we should make sure the format is at least provided as a command-line flag and not via an environment variable. An actual configuration field would be nice but since we don't have logging options in the configuration already, it would be a bit inconsistent (and I don't think that adding logging options into the config is a good-first-issue.)

@tsandall
Copy link
Member

ping @sujanks, any update?

@tsandall
Copy link
Member

Closing this for now as it's been open for 2 weeks. We can always re-open.

@tsandall tsandall closed this Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants