Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes JSON schema test failing with Go 1.17 rc #3591

Merged
merged 1 commit into from
Jun 28, 2021

Conversation

olivierlemasle
Copy link
Contributor

Replace the time 01:01:01,1111 by 14:30, which is a ISO 8601 valid time, but not a RFC3339 "full time", and is rejected as such by the TimeFormatChecker.

Fixes #3589

Replace the time "01:01:01,1111" by "14:30", which is a ISO 8601 valid time,
but not a RFC3339 "full time", and is rejected as such by the TimeFormatChecker.

Fixes open-policy-agent#3589

Signed-off-by: Olivier Lemasle <[email protected]>
Copy link
Contributor

@srenatus srenatus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🎉

@srenatus srenatus merged commit 123ba6b into open-policy-agent:main Jun 28, 2021
@olivierlemasle olivierlemasle deleted the fix1-17 branch June 28, 2021 20:31
juliafriedman8 pushed a commit to juliafriedman8/opa that referenced this pull request Jul 13, 2021
…-agent#3591)

Replace the time "01:01:01,1111" by "14:30", which is a ISO 8601 valid time,
but not a RFC3339 "full time", and is rejected as such by the TimeFormatChecker.

Fixes open-policy-agent#3589

Signed-off-by: Olivier Lemasle <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Go 1.17 - Test failure in gojsonschema time format validation
2 participants