Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FOR ALL section on Policy Language buries the lede #4603

Closed
tsandall opened this issue Apr 20, 2022 · 0 comments · Fixed by #4605
Closed

FOR ALL section on Policy Language buries the lede #4603

tsandall opened this issue Apr 20, 2022 · 0 comments · Fixed by #4605
Assignees
@srenatus
Labels
docs

Comments

@tsandall
Copy link
Member

The section on FOR ALL in the docs buries the lede (so to speak) by saying that like SQL, Rego does not have a direct way to express FOR ALL. This was true prior to the release of the every keyword, but it's no longer the case. We should revisit this section of the docs and update it to align w/ the new keyword. We should lead w/ every and then mention the alternatives (NOT-SOME-NOT or comprehensions) and explain when those are preferable to every.
@tsandall tsandall added the docs label Apr 20, 2022
@srenatus srenatus mentioned this issue Apr 21, 2022
Merged
srenatus added a commit to srenatus/opa that referenced this issue Apr 22, 2022
@srenatus
docs/policy-language: reorder Universal Quantification content
9b42c41 
We should really start with `every`, then offer alternatives, and
call out common mistakes in those alternatives after having presented
the proper solution.

Also replaces some one-letter-rule names in the detailled presentation
of `every`.

Fixes open-policy-agent#4603.

Signed-off-by: Stephan Renatus <[email protected]>
srenatus added a commit that referenced this issue Apr 22, 2022
@srenatus
docs/policy-language: reorder Universal Quantification content (#4605)
1ca73a0 
We should really start with `every`, then offer alternatives, and
call out common mistakes in those alternatives after having presented
the proper solution.

Also replaces some one-letter-rule names in the detailled presentation
of `every`.

Fixes #4603.

Signed-off-by: Stephan Renatus <[email protected]>
rokkiter pushed a commit to rokkiter/opa that referenced this issue Apr 26, 2022
@srenatus @rokkiter
docs/policy-language: reorder Universal Quantification content (open-…
ae83bc5 
…policy-agent#4605)

We should really start with `every`, then offer alternatives, and
call out common mistakes in those alternatives after having presented
the proper solution.

Also replaces some one-letter-rule names in the detailled presentation
of `every`.

Fixes open-policy-agent#4603.

Signed-off-by: Stephan Renatus <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srenatus srenatus

Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs/policy-language: reorder Universal Quantification content srenatus/opa
2 participants
@tsandall @srenatus