Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: run tests on linux/arm64 #4276

Closed
srenatus opened this issue Jan 25, 2022 · 2 comments
Closed

CI: run tests on linux/arm64 #4276

srenatus opened this issue Jan 25, 2022 · 2 comments
Labels
feature-request good first issue

Comments

@srenatus
Copy link
Contributor

Since we've started shipping binaries for that platform (#4254), it would be good to also run tests on it.

Note: the same would be true for windows; but we've skipped running tests there because of too many hardcoded assumptions about file paths in our tests. For linux/arm64, however, that should not be a problem.

The work done on the github workflow in #4254 could serve as an example: we'd run the tests on that platform via docker, using the qemu setup.
@srenatus srenatus mentioned this issue Jan 25, 2022
Closed
@srenatus
Copy link
Contributor Author

Took a stab at it but don't hesitate ripping this out of my hands of you'd like.

@srenatus
Copy link
Contributor Author

Due to #4280, we'd have to litter more build tags over the repo to be able to run the unit tests without wasm. I think that's not worth it, let's give linux/arm64 coverage when we're able to run all the things on it, not just a subset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: run unit tests on linux/arm64 srenatus/opa
1 participant
@srenatus