Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website: Search Bar Missing in Reduced-Width Window #3353

Closed
jobsolete opened this issue Apr 6, 2021 · 7 comments · Fixed by #4866
Closed

Website: Search Bar Missing in Reduced-Width Window #3353

jobsolete opened this issue Apr 6, 2021 · 7 comments · Fixed by #4866

Comments

@jobsolete
Copy link

Expected Behavior

As a user, I expect the search bar to persist when the browser window width is reduced.

Actual Behavior

The search bar disappears when the window width is reduced and zoom is set above a certain threshold.

Full Screen (Search Bar Present)

Half Screen (Search Bar Missing)

Steps to Reproduce the Problem

  1. Navigate to https://www.openpolicyagent.org/docs/latest/
  2. Reduce window width until search bar disappears.

Additional Info

Browser: Firefox 87.0 (64-bit) & Chrome Version 89.0.4389.114 (Official Build) (x86_64)
OS: macOS 11.2.3

@saharme
Copy link

saharme commented May 5, 2021

Hi,
It is not a bug, it is a feature :)

This is because the media query should be lower than what is it now (set standard value).
Now:
(min-width: 1088px)

Should be ~:
(min-width: 600px)

@stale
Copy link

stale bot commented Nov 22, 2021

This issue has been automatically marked as inactive because it has not had any activity in the last 30 days.

@stale stale bot added the inactive label Nov 22, 2021
@Parsifal-M
Copy link
Contributor

Hey Team,

Would it be okay if I pick this up? It will be my first contribution so if there is anything I should be aware of would be great! I am in the slack already :)

Thanks!

@stale stale bot removed the inactive label Jul 5, 2022
@srenatus
Copy link
Contributor

srenatus commented Jul 5, 2022

Thank you - go for it! The situation around style sheets is quite opaque, I'm afraid, let us know if you get stuck.

@Parsifal-M
Copy link
Contributor

Thanks! no worries will reach out if I get stuck!

@Parsifal-M
Copy link
Contributor

Hey @srenatus, I think I've found a good solution for this, I will make a PR later, are there any specific rules or best practices when making the PR? I may have missed them and this will be my first (and hopefully not last!)

Also, I forgot to ask, could you assign this to me?

Thanks!

@srenatus
Copy link
Contributor

Just open a PR. The checks, and the preview build on netlify, will give us a good indication of how it works. FWIW, our website stuff is a hodgepodge, so there aren't any guidelines or such a thing. Anything that works is OK 😅

srenatus pushed a commit that referenced this issue Jul 11, 2022
Updated the used bulma classes, so we will now go to hamburger on touch devices (anything under 1024px)
directly, not hide the navbar elements.

Fixes #3353.

Signed-off-by: Peter Macdonald <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants