Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump-up go version to 1.20 #837

Closed
boranx opened this issue Jun 29, 2023 · 4 comments
Closed

Bump-up go version to 1.20 #837

boranx opened this issue Jun 29, 2023 · 4 comments
Labels

Comments

@boranx
Copy link
Member

boranx commented Jun 29, 2023

This is to bump up to the latest Go version in the maintenance context. It should be straightforward/safe given there are no breaking changes for Conftest that need to be applied since 1.19

e.g:

go mod edit -go 1.20
make build
make test
make test-acceptance
make test-examples
@boranx boranx added good first issue Good for newcomers maintenance labels Jun 29, 2023
@jalseth
Copy link
Member

jalseth commented Jul 22, 2023

@boranx I don't think we want to do this just yet. When the version in go.mod is increased, all previous versions of Go cannot build the package. Go v1.19 is officially supported until 1 year after release (2023-08-03). After this date, we can bump the version.

@boranx
Copy link
Member Author

boranx commented Jul 26, 2023

ack, sounds good! Do we have a label specifying the change that needs to be done after a target date, or would it be better/more elegant closing the issue and re-open it when the maintenance window comes?

@jalseth
Copy link
Member

jalseth commented Feb 6, 2024

@boranx I don't think we have any such labels. This change can be made now, 1.19 is no longer supported.

@jalseth
Copy link
Member

jalseth commented Mar 7, 2024

Resolved in #927 because it was blocking CI.

@jalseth jalseth closed this as completed Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants