Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

osc-monitoring component build fails when osc-portals4 is configured #4523

Closed
tkordenbrock opened this issue Nov 21, 2017 · 3 comments
Closed

osc-monitoring component build fails when osc-portals4 is configured #4523

tkordenbrock opened this issue Nov 21, 2017 · 3 comments
Assignees
@tkordenbrock
Labels
bug Severity: blocker Target: main Target: v3.1.x

Comments

@tkordenbrock
Copy link
Member

The osc-monitoring configury searches for a Portals4 installation, but does not use any of the configure variables in Makefile.am. When compiling osc-monitoring, the compile fails because portals4.h cannot be found.

This problem exists on master and v3.1.x.
@tkordenbrock tkordenbrock self-assigned this Nov 21, 2017
clementFoyer added a commit to clementFoyer/ompi that referenced this issue Nov 22, 2017
@clementFoyer
Remove inter-dependencies between OSC modules.
83d39e1 
The osc monitoring component needed to include other OSC components
header in order to be able tu access communicator through the
component specific ompi_osc_*_module_t structures. This commit remove
the dependency, and resolve the issue open-mpi#4523.

Signed-off-by: Clement Foyer <[email protected]>
clementFoyer added a commit to clementFoyer/ompi that referenced this issue Nov 22, 2017
@clementFoyer
Remove inter-dependencies between OSC modules.
08ec754 
The osc monitoring component needed to include other OSC components
header in order to be able tu access communicator through the
component specific ompi_osc_*_module_t structures. This commit remove
the dependency, and resolve the issue open-mpi#4523.

Signed-off-by: Clement Foyer <[email protected]>
@clementFoyer clementFoyer mentioned this issue Nov 22, 2017
Merged
clementFoyer added a commit to clementFoyer/ompi that referenced this issue Dec 1, 2017
@clementFoyer
Remove inter-dependencies between OSC modules.
9c54a11 
The osc monitoring component needed to include other OSC components
header in order to be able tu access communicator through the
component specific ompi_osc_*_module_t structures. This commit remove
the dependency, and resolve the issue open-mpi#4523.

Signed-off-by: Clement Foyer <[email protected]>

Extend the common monitoring API.

  * Now it's possible to translate from local rank to world rank from
    both the communicator and the group.
  * Remove useless hashtable as we directly use the w_group contained
    in window structure.

Signed-off-by: Clement Foyer <[email protected]>
clementFoyer added a commit to clementFoyer/ompi that referenced this issue Dec 1, 2017
@clementFoyer
Remove inter-dependencies between OSC modules.
b24d371 
The osc monitoring component needed to include other OSC components
header in order to be able tu access communicator through the
component specific ompi_osc_*_module_t structures. This commit remove
the dependency, and resolve the issue open-mpi#4523.

Signed-off-by: Clement Foyer <[email protected]>

Extend the common monitoring API.

  * Now it's possible to translate from local rank to world rank from
    both the communicator and the group.
  * Remove useless hashtable as we directly use the w_group contained
    in window structure.

Signed-off-by: Clement Foyer <[email protected]>
@jsquyres
Copy link
Member

jsquyres commented Dec 5, 2017

Just to track a little history here:

Hence, #4521 was closed in favor of #4527. But #4527 is not yet complete.

clementFoyer added a commit to clementFoyer/ompi that referenced this issue Dec 22, 2017
@clementFoyer
Remove inter-dependencies between OSC modules.
ff207ee 
The osc monitoring component needed to include other OSC components
header in order to be able tu access communicator through the
component specific ompi_osc_*_module_t structures. This commit remove
the dependency, and resolve the issue open-mpi#4523.

Signed-off-by: Clement Foyer <[email protected]>

Extend the common monitoring API.

  * Now it's possible to translate from local rank to world rank from
    both the communicator and the group.
  * Remove useless hashtable as we directly use the w_group contained
    in window structure.

Signed-off-by: Clement Foyer <[email protected]>
clementFoyer added a commit to clementFoyer/ompi that referenced this issue Dec 22, 2017
@clementFoyer
Remove inter-dependencies between OSC modules.
9613788 
The osc monitoring component needed to include other OSC components
header in order to be able tu access communicator through the
component specific ompi_osc_*_module_t structures. This commit remove
the dependency, and resolve the issue open-mpi#4523.

Signed-off-by: Clement Foyer <[email protected]>

Extend the common monitoring API.

  * Now it's possible to translate from local rank to world rank from
    both the communicator and the group.
  * Remove useless hashtable as we directly use the w_group contained
    in window structure.

Signed-off-by: Clement Foyer <[email protected]>
clementFoyer added a commit to clementFoyer/ompi that referenced this issue Jan 9, 2018
@clementFoyer
Remove inter-dependencies between OSC modules.
48221f7 
The osc monitoring component needed to include other OSC components
header in order to be able tu access communicator through the
component specific ompi_osc_*_module_t structures. This commit remove
the dependency, and resolve the issue open-mpi#4523.

Signed-off-by: Clement Foyer <[email protected]>

Extend the common monitoring API.

  * Now it's possible to translate from local rank to world rank from
    both the communicator and the group.
  * Remove useless hashtable as we directly use the w_group contained
    in window structure.

Signed-off-by: Clement Foyer <[email protected]>

Add automatic generation at config time.

The templates are expanded at configure time. It creates a new header
file that generates all the variables/functions needed. Adding this
during the autogen automatically generates for each of the available
modules.

Signed-off-by: Clement Foyer <[email protected]>

Reduce the amount of symbols defined.

Most of variables could be static inside functions, reducing the
impact in term of used symbols.

Signed-off-by: Clement Foyer <[email protected]>

Only keep a generated argv-style array

Following Jeff's advice, the configure.m4 file generate a simple array
of module variables to be iterated over to find the proper module.

Signed-off-by: Clement Foyer <[email protected]>
clementFoyer added a commit to clementFoyer/ompi that referenced this issue Jan 10, 2018
@clementFoyer
Remove inter-dependencies between OSC modules.
efecde9 
The osc monitoring component needed to include other OSC components
header in order to be able tu access communicator through the
component specific ompi_osc_*_module_t structures. This commit remove
the dependency, and resolve the issue open-mpi#4523.

Extend the common monitoring API.

  * Now it's possible to translate from local rank to world rank from
    both the communicator and the group.
  * Remove useless hashtable as we directly use the w_group contained
    in window structure.

Add automatic generation at config time.

The templates are expanded at configure time. It creates a new header
file that generates all the variables/functions needed. Adding this
during the autogen automagicaly generates for each of the available
modules the proper functions.

Only keep a generated argv-style array.

Following Jeff's advice, the configure.m4 file generate a simple array
of module variables to be iterated over to find the proper module.

Signed-off-by: Clement Foyer <[email protected]>
clementFoyer added a commit to clementFoyer/ompi that referenced this issue Jan 12, 2018
@clementFoyer
Remove inter-dependencies between OSC modules.
0f00945 
The osc monitoring component needed to include other OSC components
header in order to be able tu access communicator through the
component specific ompi_osc_*_module_t structures. This commit remove
the dependency, and resolve the issue open-mpi#4523.

Extend the common monitoring API.

  * Now it's possible to translate from local rank to world rank from
    both the communicator and the group.
  * Remove useless hashtable as we directly use the w_group contained
    in window structure.

Signed-off-by: Clement Foyer <[email protected]>
clementFoyer added a commit to clementFoyer/ompi that referenced this issue Feb 7, 2018
@clementFoyer
Remove inter-dependencies between OSC modules.
f5b4fc0 
The osc monitoring component needed to include other OSC components
header in order to be able tu access communicator through the
component specific ompi_osc_*_module_t structures. This commit remove
the dependency, and resolve the issue open-mpi#4523.

Extend the common monitoring API.

  * Now it's possible to translate from local rank to world rank from
    both the communicator and the group.
  * Remove useless hashtable as we directly use the w_group contained
    in window structure.

Add automatic generation at config time.

The templates are expanded at configure time. It creates a new header
file that generates all the variables/functions needed. Adding this
during the autogen automagicaly generates for each of the available
modules the proper functions.

Only keep a generated argv-style array.

Following Jeff's advice, the configure.m4 file generate a simple array
of module variables to be iterated over to find the proper module.

Signed-off-by: Clement Foyer <[email protected]>
clementFoyer added a commit to clementFoyer/ompi that referenced this issue Feb 15, 2018
@clementFoyer
Remove inter-dependencies between OSC modules.
614f583 
The osc monitoring component needed to include other OSC components
header in order to be able tu access communicator through the
component specific ompi_osc_*_module_t structures. This commit remove
the dependency, and resolve the issue open-mpi#4523.

Extend the common monitoring API.

  * Now it's possible to translate from local rank to world rank from
    both the communicator and the group.
  * Remove useless hashtable as we directly use the w_group contained
    in window structure.

Add automatic generation at config time.

The templates are expanded at configure time. It creates a new header
file that generates all the variables/functions needed. Adding this
during the autogen automagicaly generates for each of the available
modules the proper functions.

Only keep a generated argv-style array.

Following Jeff's advice, the configure.m4 file generate a simple array
of module variables to be iterated over to find the proper module.

Signed-off-by: Clement Foyer <[email protected]>
clementFoyer added a commit to clementFoyer/ompi that referenced this issue Feb 15, 2018
@clementFoyer
Remove inter-dependencies between OSC modules.
532d392 
The osc monitoring component needed to include other OSC components
header in order to be able tu access communicator through the
component specific ompi_osc_*_module_t structures. This commit remove
the dependency, and resolve the issue open-mpi#4523.

Extend the common monitoring API.

  * Now it's possible to translate from local rank to world rank from
    both the communicator and the group.
  * Remove useless hashtable as we directly use the w_group contained
    in window structure.

Add automatic generation at config time.

The templates are expanded at configure time. It creates a new header
file that generates all the variables/functions needed. Adding this
during the autogen automagicaly generates for each of the available
modules the proper functions.

Only keep a generated argv-style array.

Following Jeff's advice, the configure.m4 file generate a simple array
of module variables to be iterated over to find the proper module.

Signed-off-by: Clement Foyer <[email protected]>
@clementFoyer
Copy link
Contributor

#4527 is merged, thus clothing this Issue for target: master.
#4817 is approved, waiting to be merged in order to close for target: v3.1.x

@bwbarrett
Copy link
Member

Both master and 3.1.x now have the patch, so closing this issue.

thananon pushed a commit to thananon/ompi that referenced this issue Apr 4, 2018
@clementFoyer
Remove inter-dependencies between OSC modules.
63249b0 
The osc monitoring component needed to include other OSC components
header in order to be able tu access communicator through the
component specific ompi_osc_*_module_t structures. This commit remove
the dependency, and resolve the issue open-mpi#4523.

Extend the common monitoring API.

  * Now it's possible to translate from local rank to world rank from
    both the communicator and the group.
  * Remove useless hashtable as we directly use the w_group contained
    in window structure.

Add automatic generation at config time.

The templates are expanded at configure time. It creates a new header
file that generates all the variables/functions needed. Adding this
during the autogen automagicaly generates for each of the available
modules the proper functions.

Only keep a generated argv-style array.

Following Jeff's advice, the configure.m4 file generate a simple array
of module variables to be iterated over to find the proper module.

Signed-off-by: Clement Foyer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tkordenbrock tkordenbrock

Labels
bug Severity: blocker Target: main Target: v3.1.x
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jsquyres @clementFoyer @tkordenbrock @bwbarrett